From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 592DB369D61; Sat, 12 Sep 2026 19:24:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241048; cv=none; b=aba8ExUZ9R5bJ4tCAFZQS8D2ctl9yhlxRrISp+goU7zLlqrkvv2m4Vg2FXvnri4tqIGmcNN9mXNfJ94Gwc1qR7AnXsMr5EgmS5eku3Gqi7yHWEqF5fLg2CRAYJpzyqnrqI5nLystft61+6blaUUYcOdl43DO3e1FDH7TFFmk5W8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241048; c=relaxed/simple; bh=DjYzIef7gtzQYW2nK15yEShaohE0QpKqYI78Ppx2ZLo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gRYIUlDgL/fjaHM8oUTecb7AeS28aoSgO34jg2XhCzMyRwnp3a66SnYW0rDmnROjUe+KqlGH8iD6oMhkW+hRJ6VWl1DdmEn2k6FmkYeNLFwjxDJc1Ah5APfqJxoUVfFKj891QV6a8PPUX3kd7ahtC9rsSwnIMsDnJ/lCwvCcUoY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=AwU6DE1u; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="AwU6DE1u" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1FCEA1F000FF; Sat, 12 Sep 2026 19:24:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241046; bh=11PTo117fZfCGTlMtDBJrnAxRZyrOG6OB3/SxTiQ0kc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AwU6DE1uAvLua7ul9vb6h/i3R16M5jCwSfOfNLm2zBwuYo4cQmRGYSc8egXOiIBJR idU8fl2/HRuQ1QzSG46O0+dqdFHyWcZsmjtLA4u3XwIZ7CPItO3dqviThZClBpvdbB VieZIvtQqRJ+m4bUk3gdyMTqn+rVY/TfOYrDPbxo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Xu Rao , Jiri Kosina Subject: [PATCH 5.10 054/798] HID: roccat: free buffered reports when destroying device Date: Sat, 12 Sep 2026 08:54:42 +0200 Message-ID: <20260912065518.200583644@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xu Rao commit bbff0ccbff360a5498075525005f6a913239a3d7 upstream. roccat_report_event() duplicates each report with kmemdup() and stores the allocation in a circular-buffer slot. The allocation is released only when that slot is reused. The device destruction paths free struct roccat_device without releasing reports still stored in cbuf[]. This makes those allocations unreachable and leaks up to ROCCAT_CBUF_SIZE report buffers per device. Add a small destructor that frees every buffered report before freeing the device, and use it in both paths that can destroy a registered device. Fixes: 206f5f2fcb5f ("HID: roccat: propagate special events of roccat hardware to userspace") Cc: stable@vger.kernel.org Signed-off-by: Xu Rao Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-roccat.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) --- a/drivers/hid/hid-roccat.c +++ b/drivers/hid/hid-roccat.c @@ -70,6 +70,15 @@ static struct roccat_device *devices[ROC /* protects modifications of devices array */ static DEFINE_MUTEX(devices_lock); +static void roccat_free_device(struct roccat_device *device) +{ + int i; + + for (i = 0; i < ROCCAT_CBUF_SIZE; i++) + kfree(device->cbuf[i].value); + kfree(device); +} + static ssize_t roccat_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) { @@ -226,7 +235,7 @@ static int roccat_release(struct inode * hid_hw_power(device->hid, PM_HINT_NORMAL); hid_hw_close(device->hid); } else { - kfree(device); + roccat_free_device(device); } } @@ -374,7 +383,7 @@ void roccat_disconnect(int minor) hid_hw_close(device->hid); wake_up_interruptible(&device->wait); } else { - kfree(device); + roccat_free_device(device); } } EXPORT_SYMBOL_GPL(roccat_disconnect);