From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1D4E331EA8; Sat, 12 Sep 2026 19:24:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241084; cv=none; b=khgzhX4vj7PRt/G/Kk2tSvKSfmnksHBGlJ1rQzn898U0k/rcm/Ev5gAs15RFmN4cpKD3Hh5adDraemmi+kPKZSTr5VLYoh9ux6/YCGfSnnTSi9YaOAqTpAkah6eX6SNS7kVibD4A5v8jA81yOP+Ic29Zlu8+TgkUvZziekgfRBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241084; c=relaxed/simple; bh=lpSFigDjEOuMihgCcmLEcgzIJEJuxUPeZ7WEbHZvts4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EJSKeuTtnRHEO9fpYdTtfMVXu8eNLL9i/eQYBfSrebqxYym8W4pdpBVyvpLwJHUQ840Rluwrnu/n9FqCcy4gN8Y1IXHUVju68TS8Y1mNHlf2KIhEiXceaIsHiKz9983YXO8ICW45GDKPi/SaCmiiuseiyTTSfDGrJ/6vTLCqY04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=iJkAsV/W; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="iJkAsV/W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDFD61F000FF; Sat, 12 Sep 2026 19:24:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241082; bh=sIXLgP3FvCgNDbp9CIf8E10INb97WAkkqcwuwx8S4pc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iJkAsV/WgZXa35NFHaf7+gqzr9fxHyx5tg+FEobMnarEKwLwzjbv/HHZViXp5fSD6 J+ZHU5vUrEVWbAQcn++7bMDd7jCcV/FrD1TeNwFPciW3Y6Rl0T36UWG9lxAiTrAkDC 3C4lorlAjYn4cXTTlX3V3LGEjvYl/2czP9J4rk8Q= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jiangshan Yi , Jiri Kosina Subject: [PATCH 5.10 056/798] HID: mcp2221: validate report size in mcp2221_raw_event() Date: Sat, 12 Sep 2026 08:54:44 +0200 Message-ID: <20260912065518.245904740@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jiangshan Yi commit 2c9a6998c19503626c57a2267bf279e204113079 upstream. mcp2221_raw_event() never validates the size of incoming HID reports. In the MCP2221_I2C_GET_DATA path it trusts the device-supplied data[3] as the copy length without checking that 4 + data[3] bytes actually exist in the received report. A malicious or misbehaving USB device can send a short report with a large data[3], causing the memcpy to read past the valid report data in the HID transfer buffer and leak uninitialized kernel memory back to userspace through the I2C/SMBus read path. Add a minimum size check at entry and validate that the source range fits within the received report before the copy. Fixes: 67a95c21463d ("HID: mcp2221: add usb to i2c-smbus host bridge") Cc: stable@vger.kernel.org Signed-off-by: Jiangshan Yi Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-mcp2221.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/hid/hid-mcp2221.c +++ b/drivers/hid/hid-mcp2221.c @@ -739,6 +739,9 @@ static int mcp2221_raw_event(struct hid_ u8 *buf; struct mcp2221 *mcp = hid_get_drvdata(hdev); + if (size < 4) + return 0; + switch (data[0]) { case MCP2221_I2C_WR_DATA: @@ -797,6 +800,10 @@ static int mcp2221_raw_event(struct hid_ mcp->status = -EINVAL; break; } + if (4 + data[3] > size) { + mcp->status = -EINVAL; + break; + } buf = mcp->rxbuf; memcpy(&buf[mcp->rxbuf_idx], &data[4], data[3]); mcp->rxbuf_idx = mcp->rxbuf_idx + data[3];