From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 354B637E2F3; Sat, 12 Sep 2026 19:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241226; cv=none; b=dcGZPncQIO7nqC2wAyF8+51MtjfGboaEutGffayH82kKhLolM59wNS5TTKdPxBPhjGT4R5qA6/sz1T45zDHEQXXMXBcepG3JXUrOuYKBwQzUSMEr4rnuTskE6Z/Db1ry89a0pbx0n2VCIYzluy+JQq21sMKGBewbI8k4dW/4scg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241226; c=relaxed/simple; bh=UZHGSU3JyXh+ldzLIIqg7Yw2N3cHIzns8aMO7eTtalo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ls0by8GGh/ucohDAZrIvlZCd3F4HFeg5xkSScUUam5AL4zmePknqFx2HgISRakXRV5DxC1dakvDGRswifqiXY32SFZr+9VA4xFBF+5q0HE0AEKrXZMW2/wqZ/YGKHwg2TXOYqFmIbf0Bb2iU2Vmb+5b8t8zYX8j3Um+tqEMUzsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RC8aXb7w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RC8aXb7w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBC301F000FF; Sat, 12 Sep 2026 19:27:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241225; bh=owym4jN8Gv7K47jBJxMgPMgHwP1ZAshI3ClTnxzZzoM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RC8aXb7wplJwSXHMy9H2cBVZTxgElToTlPTo0ifviRXzg6D5F2lGNs6k5zZQ2FKZy HLIbIbaadTCoWkOUDS4UG1AzUxPerERsNcshGuh7Ix4ciBicNprr4kQqp7RAMVn+xO Xnh8RBcrH32YGdLj4GQYNV02nLGvSO4ADi31u0FA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Alison Schofield , Bryam Vargas Subject: [PATCH 5.10 091/798] libnvdimm/labels: Prevent integer overflow in __nd_label_validate() Date: Sat, 12 Sep 2026 08:55:19 +0200 Message-ID: <20260912065519.043018665@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bryam Vargas commit 037770686126155eafc44501312989e2837b9659 upstream. The on-media namespace index field nslot is a u32 read from the DIMM label storage area. __nd_label_validate() bounds it against the config area size, but sizeof_namespace_label() returns unsigned, so the product nslot * label_size is evaluated in 32-bit and wraps modulo 2^32 before the comparison. A crafted nslot passes the bound and is then used as the loop trip count in nd_label_data_init(), whose memset() walks off the end of the config_size buffer: an out-of-bounds write. The field is not trusted -- it comes from the medium, or from userspace via ND_CMD_SET_CONFIG_DATA. Evaluate the product in 64-bit so the bound check is exact; conforming labels are unaffected. The check was safe when introduced by commit 4a826c83db4e ("libnvdimm: namespace indices: read and validate"): it multiplied by sizeof(struct nd_namespace_label), a size_t, so on a 64-bit build the product did not wrap. Commit 564e871aa66f ("libnvdimm, label: add v1.2 nvdimm label definitions") narrowed it to 32 bits when the label size became a runtime value read via sizeof_namespace_label(). Fixes: 564e871aa66f ("libnvdimm, label: add v1.2 nvdimm label definitions") Cc: stable@vger.kernel.org Reviewed-by: Alison Schofield Signed-off-by: Bryam Vargas Link: https://patch.msgid.link/20260624-b4-disp-d8279485-v3-1-cdb6cab28b41@proton.me Signed-off-by: Alison Schofield Signed-off-by: Greg Kroah-Hartman --- drivers/nvdimm/label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/nvdimm/label.c +++ b/drivers/nvdimm/label.c @@ -194,7 +194,7 @@ static int __nd_label_validate(struct nv } nslot = __le32_to_cpu(nsindex[i]->nslot); - if (nslot * sizeof_namespace_label(ndd) + if ((u64)nslot * sizeof_namespace_label(ndd) + 2 * sizeof_namespace_index(ndd) > ndd->nsarea.config_size) { dev_dbg(dev, "nsindex%d nslot: %u invalid, config_size: %#x\n",