From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66A4F78C9C; Sat, 12 Sep 2026 19:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241260; cv=none; b=OmZdexdzpvhaFSvRK83EEozIyg9iBXdpRpJJwaGhU9QV4uOcfrSsvHhpAg1tluyt8p+EEkjGg4ANrmCpU/gp4Ewk+LsTMMfskwiRXmD4m3UUiWgk44tLxGAlX3o5ojqh1q6M7W6DEuEArYEmg6WWDNPkmqiS/8vySSRhhsHXj1A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241260; c=relaxed/simple; bh=RdgtIDY7EvGpfRSyBGeEU+qmQMMf8dACXmJnh4VzOnY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B1rqQ+OVKsy2jU7aclPTxbvOl3PdSsUpA2F3zpVfJke3QHFRKZAplbu4Im3jAP4fqw1KrZbGh03RdeiPNHrnh3BThVNlEafAnYn0wSnbm9AL8x2YTAMbCt0DeHR3GFf0IPfXCAUbXB3/p7RjqumsSHtgzDWWw59ibsVVORacjOg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EjgOGHB8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EjgOGHB8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B7711F000FF; Sat, 12 Sep 2026 19:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241259; bh=7flqHJ29pkdSn+3CmPJOnbcc5uFpqg1VUFc5dhCPXbg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EjgOGHB8UdTcfMWbF+YiDKxaKacD4kDIOO6QTyFC0/mNYrfM27vSwGPK9/z7HQ14J LC9lmc3XPONQbg0Cf2GS9aSJB52PihGgMM3QlEW6dqHVaHIKE0vr54EROmydpBM44d fQXIW+RUSaChr1Ezv2Ic560p7Xl1eqKCYBAldreA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeff Layton , Chuck Lever Subject: [PATCH 5.10 097/798] SUNRPC: always drain cache_cleaner before destroying a cache_detail Date: Sat, 12 Sep 2026 08:55:25 +0200 Message-ID: <20260912065519.180759081@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeff Layton commit f42d0fda0c67695db6bc704b04b7c10240805377 upstream. sunrpc_destroy_cache_detail() only cancels the global cache_cleaner delayed_work when cache_list is empty. During per-netns teardown cache_list is never empty because init_net's caches remain registered, so the cancel never fires. After unlink, the caller proceeds to cache_destroy_net() which kfrees the cache_detail while cache_clean() may still hold a dangling pointer to it. The result is a use-after-free: cache_dequeue() takes cd->queue_lock on freed memory, and cache_put() dereferences cd->cache_put as a function pointer from freed slab. Drop the list_empty guard so that cancel_delayed_work_sync() always runs, ensuring any in-flight cache_clean() completes before the cache_detail is freed. Re-arm the cleaner afterwards if other caches are still registered. Fixes: 820f9442e711 ("SUNRPC: split cache creation and PipeFS registration") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-6 Signed-off-by: Jeff Layton Link: https://patch.msgid.link/20260526-cache_cleaner_vs_destroy_no_sync-v1-1-a707a6fcfd32@kernel.org Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- net/sunrpc/cache.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -410,10 +410,9 @@ void sunrpc_destroy_cache_detail(struct list_del_init(&cd->others); spin_unlock(&cd->hash_lock); spin_unlock(&cache_list_lock); - if (list_empty(&cache_list)) { - /* module must be being unloaded so its safe to kill the worker */ - cancel_delayed_work_sync(&cache_cleaner); - } + cancel_delayed_work_sync(&cache_cleaner); + if (!list_empty(&cache_list)) + queue_delayed_work(system_power_efficient_wq, &cache_cleaner, 0); } EXPORT_SYMBOL_GPL(sunrpc_destroy_cache_detail);