From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2004637F8D7; Sat, 12 Sep 2026 19:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241533; cv=none; b=A2RT0hn4VnxADdJqA3ceB9zWXFMAJjM0e5dCn5MfKMtHoO0sZsXL1qbhG2Pllriharsp84cylhhUcMB+68Vm5/9n8vq3cFxKWf8lmQKREL6tRsNo7NmkbNthbEQxuMEz7vsLLX+UUw2pWBfGdieYI9nUxovjXKb/mpApUQCD1KM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241533; c=relaxed/simple; bh=280d9X8uoyKO6JkJBdPoN+iZhiDnB2IUQR4Fitm7zI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DyH3AceXyuAbrfuDVrB8Gp6uVeS2SyrhOJNL31qbMlGTZdDr7zBfMPV+oCQMdUj9NkkYVlifRXDooMd2b4eJBOL4jVIuXWatmXFpTwn3QdFAvYENDCswxM56PpcEqDMpw7jL0pm7BVOfOMaRnjHcrdOEaGGd3idb8Ug5s/2o4xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Xxrzyp+e; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Xxrzyp+e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C36F11F00893; Sat, 12 Sep 2026 19:32:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241532; bh=zven9hwxFnFP2QwCWqsTqDm4zch46bp6UuK6p0PpB28=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Xxrzyp+eRNmKX81bt4Yyi5MaBjscnYf8ajLxfRlfuDG5gZZ2oMl77ZkiakuO8Bem5 t54SV85LG3vak2qOY9tKBuWvXYzKxGYuNjcAkekLVyWCSLPwhCWe/QlHE6ysujnyyL fOmFO4gzp5ibATrvWY2bcHpvPFJXNWiEhECtLE48= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Ulf Hansson Subject: [PATCH 5.10 148/798] mmc: via-sdmmc: stop card-detect handling on probe failure Date: Sat, 12 Sep 2026 08:56:16 +0200 Message-ID: <20260912065520.388707282@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit 088eaa92fcebaa6b957ccf9635afdf39643a577d upstream. request_irq() registers the SD card-detect interrupt and the probe enables it before mmc_add_host() runs. If mmc_add_host() fails, the error path only unmaps the registers and returns: the interrupt stays registered, so the handler keeps running against the host once it is freed. via_sdc_isr() dereferences sdhost and its MMIO base and schedules carddet_work, which via_sdc_card_detect() also runs against freed memory through its container_of() dereference. Add a probe-error path that disables and frees the interrupt and cancels carddet_work before unmapping. carddet_work can re-enable the device interrupt via via_reset_pcictrl(), which restores PCIINTCTRL, so mask it again after cancelling the work. This issue was found by an in-house static analysis tool and confirmed by manual code review. Fixes: e4e46fb61e3b ("mmc: via-sdmmc: fix return value check of mmc_add_host()") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/via-sdmmc.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- a/drivers/mmc/host/via-sdmmc.c +++ b/drivers/mmc/host/via-sdmmc.c @@ -1156,10 +1156,16 @@ static int via_sd_probe(struct pci_dev * ret = mmc_add_host(mmc); if (ret) - goto unmap; + goto free_irq; return 0; +free_irq: + writeb(0x0, sdhost->pcictrl_mmiobase + VIA_CRDR_PCIINTCTRL); + free_irq(pcidev->irq, sdhost); + cancel_work_sync(&sdhost->carddet_work); + /* carddet_work may re-enable the interrupt via via_reset_pcictrl(). */ + writeb(0x0, sdhost->pcictrl_mmiobase + VIA_CRDR_PCIINTCTRL); unmap: iounmap(sdhost->mmiobase); free_mmc_host: