From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25480344DBD; Sat, 12 Sep 2026 19:33:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241641; cv=none; b=CmaeGvJ3x0/wNPKL/wWTiFj268CcVEQtkhl4QjUiCXbWMOPx3O3PF1rFjnvnRCuFZix+7wzhy7XFMi0YAT/bf7bsobtjLYV2QY7DButN3EXReU0r/QOLT5xNO2McHQA5tiDXpI2Mdaze/lsQQQLrNLV6fR5BTOrpDGhtb92d8BU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241641; c=relaxed/simple; bh=tFbdtXhVYlFs1NoSsz4XGtNB+VU7vNydUGYtu4Xdt/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kV5e2QmM7WwLc5tC664OEq7/93ZQtZCJqJnpSjhjtseTxT9bF50BjI4W7eySeD57OltJk8Lxlf0KIxcwn9nH5/OWoIZLdEqlIL8lSU+Em7793AcdwVOjzjhUhc27iiN2mwjvB0zhCHUzpGew6GGbhmPAt2tJbFGG96U+wkF0L28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=dZjGQ+CN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="dZjGQ+CN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F00D1F000FF; Sat, 12 Sep 2026 19:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241639; bh=JrKex99wk+OeiiHIHSSqAK2ngidHxdJBSws4hh9uIl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=dZjGQ+CNycAm2Q4/rDcGbkhxdfmil2Lnbbv2aDHMAfNDzuBGwIK5luScBUZdc5ji5 BWD3FXtK7WNTsZaERt2brHdpkZxDeFsp2dBFEW7LtV+uEOrpCBFPJa/UHK4GGlGeFL 0WZTB30Ep+TPIGKYJciPV5a9Fs0YyRK3cbXg30AM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Kuan-Wei Chiu , Georgi Djakov Subject: [PATCH 5.10 150/798] interconnect: Fix use after free in icc_get() and of_icc_get_by_index() Date: Sat, 12 Sep 2026 08:56:18 +0200 Message-ID: <20260912065520.440244355@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Kuan-Wei Chiu commit 25c7e242aca084fdc1098248194032317dca625d upstream. In of_icc_get_by_index() and icc_get(), if the dynamic allocation for path->name fails via kasprintf(), the error handling path directly calls kfree(path) to free the path object and returns an error. However, prior to this point, path_find() calls path_init(), which already links the path's requests into the req_list of the respective interconnect nodes via hlist_add_head(). Directly invoking kfree(path) leaves dangling pointers in the hlist. A subsequent call to icc_get() or icc_set_bw() will traverse or modify these corrupted lists, triggering a slab use afterfree. KASAN report showing the vulnerability when reproducing via debugfs: BUG: KASAN: slab-use-after-free in path_find+0x6f8/0xcfc Write of size 8 at addr fff000000d43f748 by task sh/1 ... Call trace: kasan_report+0xac/0xfc path_find+0x6f8/0xcfc icc_get+0x148/0x380 icc_get_set+0xf8/0x2d0 ... Freed by task 1: kfree+0x1a0/0x4a4 icc_get+0x2cc/0x380 icc_get_set+0xf8/0x2d0 Fix this by replacing kfree(path) with the proper teardown function, icc_put(path), which safely removes the requests from the req_list using hlist_del() and drops the provider usage references before freeing the memory. Additionally, in icc_get(), ensure that the icc_lock mutex is released prior to calling icc_put(path) to avoid a deadlock, as icc_put() internally acquires the same lock. Fixes: 3791163602f7 ("interconnect: Handle memory allocation errors") Cc: stable@vger.kernel.org Signed-off-by: Kuan-Wei Chiu Link: https://patch.msgid.link/20260416190840.1753468-1-visitorckw@gmail.com Signed-off-by: Georgi Djakov Signed-off-by: Greg Kroah-Hartman --- drivers/interconnect/core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) --- a/drivers/interconnect/core.c +++ b/drivers/interconnect/core.c @@ -507,7 +507,7 @@ struct icc_path *of_icc_get_by_index(str path->name = kasprintf(GFP_KERNEL, "%s-%s", src_data->node->name, dst_data->node->name); if (!path->name) { - kfree(path); + icc_put(path); path = ERR_PTR(-ENOMEM); } @@ -747,8 +747,9 @@ struct icc_path *icc_get(struct device * path->name = kasprintf(GFP_KERNEL, "%s-%s", src->name, dst->name); if (!path->name) { - kfree(path); - path = ERR_PTR(-ENOMEM); + mutex_unlock(&icc_lock); + icc_put(path); + return ERR_PTR(-ENOMEM); } out: mutex_unlock(&icc_lock);