From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2EBF2D0C94; Sat, 12 Sep 2026 19:37:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241853; cv=none; b=tbrfotMYrjcaTdq7HahRuSEmcieWR5Xg6lnEunP1vB/458rL2JQ2Dp04wGKCaAb6sBGTh+W7vwZXQRHmvT2Bd6R6NQVgaR2zsJU5ldu08V7y0lyhOVRgauPNOt0+eukEqrAJDKP5eB6t/gx8ZEL+VbTGfWGCj23IoZICQ9DeZNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241853; c=relaxed/simple; bh=VWlD9CL0SPdibD+LKGJyi8if8ettvMQXMXkxBFZsEOA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sxWy5gQUSVK7Bw6MqcdA+mkPpRyApg2IxCwaQFEgXrCzt6E0m+/p6N58XnvENsAfzljqj2jVP3K7XF+GMskxHPQCZ8iAHKKjAR9/C2aD84Ts+o/XwD+LblNzLau/OUtrQz8H7ckZPDzQZwN3thiT1KT4Uuy2J4xzOHHJeWsjmGE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=aTriG06R; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="aTriG06R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7DAA11F000FF; Sat, 12 Sep 2026 19:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241852; bh=nVXGwEebwFcAthuy1U642/NWXxNYgrLPVjiweXrSLGk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aTriG06RQequZ6rIXMjaOcl0Ss2Hjesle+W/Ck2JPxWyIsBfK8rt20nXagsUdfip0 V/BxxrG1U7KtamnqmODfk5uAx0iD/n557Ik/w4eySVzTzu14WP9vWHCPiaX5qW781+ cEEKE0z6sKM8UR5lNMqSmKg7j0eE4J6ojZqbCJw8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Bilal Subject: [PATCH 5.10 221/798] staging: rtl8723bs: fix OOB read in rtw_action_frame_parse() Date: Sat, 12 Sep 2026 08:57:29 +0200 Message-ID: <20260912065522.189985731@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal commit ff917923f4fb9c83717ba135ee47d7e4c1567bb7 upstream. rtw_action_frame_parse() takes a frame_len parameter but never actually checks it before indexing into the frame body: const u8 *frame_body = frame + sizeof(struct ieee80211_hdr_3addr); ... c = frame_body[0]; ... a = frame_body[1]; frame_body already points 24 bytes (sizeof(struct ieee80211_hdr_3addr)) into frame, so reading frame_body[0] and frame_body[1] requires frame_len >= 26. A management action frame shorter than that (e.g. exactly 24 bytes, the minimum a malicious peer can send) causes a 1-2 byte out-of-bounds read. This is reachable from rtw_cfg80211_monitor_if_xmit_entry() and cfg80211_rtw_mgmt_tx() in ioctl_cfg80211.c, both of which pass attacker/user-influenced frame buffers and lengths straight through. Add the missing length check before frame_body is dereferenced. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260728125456.32359-3-meatuni001@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -1291,6 +1291,9 @@ int rtw_action_frame_parse(const u8 *fra u8 c; u8 a = ACT_PUBLIC_MAX; + if (frame_len < sizeof(struct ieee80211_hdr_3addr) + 2) + return false; + fc = le16_to_cpu(((struct ieee80211_hdr_3addr *)frame)->frame_control); if ((fc & (IEEE80211_FCTL_FTYPE|IEEE80211_FCTL_STYPE))