From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40C4426299; Sat, 12 Sep 2026 19:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241878; cv=none; b=gArKXhvctHe50aMfu+Oil+gqTkWJ7/7jOiy6/RUZ6rm5yWX5ZnwLrY/1kslAhIlMgxtZ4l+nU4MlVRcn6Z2S45P7tpHlgTFAUcS1oH38rXqeFgXoq/VcOExw7mXMWQf/1rHGlTTb12PlUeGEmyd/QQl3xVVWabg9zJmVIZGcUGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789241878; c=relaxed/simple; bh=/hborw5gcSvhtIlR6nSTjIKXTfOsuaumOiQaTpk8m04=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jBv87yfyYnMg/f7OlINuIg8ze/fcWwHB64X9/HWs9u7kapVYZ8wAa/KeEZh09vT0kjgpPkqvivfIYx7MZhX8gRb5BcO3MCgZTDkcdWSUJHvVg7758lz5IY6IbYmgoOoqX0LnG3UZqgQ+0v4OCmOg7Zz63IWTOHlubtwqz5YpOzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nszewx5Y; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nszewx5Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 119291F000FF; Sat, 12 Sep 2026 19:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789241877; bh=mjEROU7+xB8IsyDx0OXL7gpL4eY3J5Z17GO/JACV3nk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nszewx5Y8rMp5MsXxtMzI9MD7XDMqenmSgbfeHQjg/H/z4SNBmR+pmqonddgiEEVK 6E4r2vTZ/NERLx8FftkPfHLy5upgqCfkbj3bFhiCBtdSErnfEFUwkINywhe1QceQLR LgLcQN5mNDuoJG7r5wZv2D6mLBseNJuzKEOWeJhE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Runyu Xiao , Jack Wang , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.10 225/798] scsi: pm8001: Use rollback index when freeing MSI-X vectors Date: Sat, 12 Sep 2026 08:57:33 +0200 Message-ID: <20260912065522.291866838@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Runyu Xiao commit 3f92a64545165bdbb36dee8fa35626b295463313 upstream. pm8001_request_msix() unwinds previously registered handlers with free_irq() when request_irq() fails. The rollback loop uses the failing index i for every iteration instead of the already registered vector index j. That passes the wrong IRQ/dev_id pair to free_irq() and leaves the earlier handlers installed. Use j for both pci_irq_vector() and the matching irq_vector entry in the rollback loop. Fixes: a76037ff3479 ("scsi: pm8001: switch to pci_irq_alloc_vectors") Cc: stable@vger.kernel.org Assisted-by: Codex:GPT-5 Signed-off-by: Runyu Xiao Acked-by: Jack Wang Link: https://patch.msgid.link/20260824113618.2239100-1-runyu.xiao@seu.edu.cn Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/pm8001/pm8001_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/scsi/pm8001/pm8001_init.c +++ b/drivers/scsi/pm8001/pm8001_init.c @@ -971,8 +971,8 @@ static u32 pm8001_request_msix(struct pm &(pm8001_ha->irq_vector[i])); if (rc) { for (j = 0; j < i; j++) { - free_irq(pci_irq_vector(pm8001_ha->pdev, i), - &(pm8001_ha->irq_vector[i])); + free_irq(pci_irq_vector(pm8001_ha->pdev, j), + &pm8001_ha->irq_vector[j]); } pci_free_irq_vectors(pm8001_ha->pdev); break;