From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2941F380FFB; Sat, 12 Sep 2026 19:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242020; cv=none; b=t0xf+okWKXPa1QqKobjFsDpF9HMj5NFXyBLxa8U+2c9zroDWKUWge73EyQS63aXIDwaea/ru6V8ho41TsKcicz26F7bjOCY3Sp7jyGJUHrOfcJXOCYRePnI5Hr5Iy5MJ7t5/Z32Pub/oulP7Y8ra0tDk2k3wnPl4s/NxYR8BYAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242020; c=relaxed/simple; bh=F+PbmmiNQjYWZbQM6RB6dPskgKNnSrVSK7FWjhC/TEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tI4pn6lpqx9Xywu3LnLyaM15+eGlmzdAQSxC/aw6WxDkulWTyYLf4E2BLT+/4qIBqaRjP9a0JoslFcnNGok4A711Q6Ph955NmQET7CgkSN9Tqcp9jAom36e6OdpShCOJaBlxRaftD1yJG0ixh+DTWAZ5A8/B6PMK7Hn2tpCZmNc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uFw0OnXS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uFw0OnXS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 497B81F000FF; Sat, 12 Sep 2026 19:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242018; bh=NWtG6KvzyAd9ZNI9tw9VMdiNAnkJGhqAseE+DOuX2G4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uFw0OnXS1frYRKGgdadFcEyZtfqeE1QVV2jevLrfIskhQ/cslszkia3lRIWc9dK0D cfKvAaBLRsWEc4TTk/7Ph7DL3mgp56CrhUu8BiuV+vJMNGfi2iLBwrS7Dht0z3a2F5 saZNnB/v9/oQwj6LirCVQ9UKRvGgsK/L8iQgW2HE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cong Nguyen , Linus Walleij , Joshua Crofts , David Lechner , Jonathan Cameron Subject: [PATCH 5.10 258/798] iio: gyro: mpu3050: fix sign of raw angular velocity readings Date: Sat, 12 Sep 2026 08:58:06 +0200 Message-ID: <20260912065523.073020524@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Nguyen commit 06fab97602fe400bea843176f485bbac07a668e2 upstream. The MPU-3050 gyroscope output registers hold 16-bit two's complement values; the angular velocity channels are declared with .sign = 's'. When mpu3050_read_raw() handles IIO_CHAN_INFO_RAW it reads the register via a big-endian regmap_bulk_read() and assigns it with: *val = be16_to_cpu(raw_val); be16_to_cpu() yields an unsigned 16-bit quantity, so negative rates (bit 15 set) are reported to userspace as large positive integers (e.g. -1 becomes 65535) instead of the correct negative value. Cast to s16 before the assignment, matching the temperature channel a few lines above which already handles the sign correctly. Fixes: 3904b28efb2c ("iio: gyro: Add driver for the MPU-3050 gyroscope") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4 Signed-off-by: Cong Nguyen Reviewed-by: Linus Walleij Reviewed-by: Joshua Crofts Reviewed-by: David Lechner Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/gyro/mpu3050-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -354,7 +354,7 @@ static int mpu3050_read_raw(struct iio_d goto out_read_raw_unlock; } - *val = be16_to_cpu(raw_val); + *val = (s16)be16_to_cpu(raw_val); ret = IIO_VAL_INT; goto out_read_raw_unlock;