From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F6637883C; Sat, 12 Sep 2026 19:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242031; cv=none; b=STPG4pWemgaXeeOyS5eoiim0Wq5+HinkJtR/E5+lmoMLE0vJGCxkxuQnpJTzCmQzGVlWtued/L59T3NUplplxHJ0li5Mtgmnch38/v2vIcHs9tbldntAaLQTFJWrmtr7Le/qiQS4r1g44AI+jIXX6On0nNsiVpKvKy7fL/PDR4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242031; c=relaxed/simple; bh=ycvIP+3Wjj9zyB2g9wM6gSj0kemZMDeEHBE0nRx/z54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sgyHM8NvmLIe1TiwVEwBRro3pDYubASLWse2C5h32P3UguwjLqJ6eiSvTYyEZ9e8msxJG1qXdNaZKIo/vRfIwiVL18CM5BkRDEtgFXIdI8RCRACgG2BVTueZ4WCpWO6rSQgI8DFGqtUNeciAOh6xYVzmA0qioGhyOEVRg3I/WFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=l+u4tHRK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="l+u4tHRK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AAB971F00893; Sat, 12 Sep 2026 19:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242030; bh=+l5TQJPhbjhIbyvpufXwo2eFGSWIe0iGIsKQFfTzlWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=l+u4tHRKymB/Tl2ItPCWbq86cSzq5IjR4FpHIoUIOXtffFA08W618BWkpZpGsJRpd clbos3AWhAVY03ZOqR8zPJDzlg2M2QMcvgm/VhGL2Hi+cdM9zVn2SlyURRlWxXT3lq 0VcaECh/XVzt2T3Hxo6ZeQHtv/zyM8FEHX721VG8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Cong Nguyen , Jonathan Cameron Subject: [PATCH 5.10 261/798] iio: srf04: fix pm_runtime handling on probe error path Date: Sat, 12 Sep 2026 08:58:09 +0200 Message-ID: <20260912065523.142023476@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Cong Nguyen commit a40b2e7a17f26e38ab054363c9c7cde149588357 upstream. When pm_runtime_set_active() fails during probe, the driver logs the error and unregisters the IIO device, but then falls through and still calls pm_runtime_enable() before returning the error. Since probe returns an error, srf04_remove() is never called, so runtime PM is left enabled without a matching pm_runtime_disable(). This leaks the enable and triggers an "Unbalanced pm_runtime_enable!" warning on a subsequent bind of the device. Return the error right after unregistering the IIO device so that runtime PM is not enabled on the failure path. Fixes: 2251157b335b ("iio: srf04: add power management feature") Cc: stable@vger.kernel.org Signed-off-by: Cong Nguyen Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/proximity/srf04.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/iio/proximity/srf04.c +++ b/drivers/iio/proximity/srf04.c @@ -336,6 +336,7 @@ static int srf04_probe(struct platform_d if (ret) { dev_err(data->dev, "pm_runtime_set_active: %d\n", ret); iio_device_unregister(indio_dev); + return ret; } pm_runtime_enable(data->dev);