From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5938367B65; Sat, 12 Sep 2026 19:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242128; cv=none; b=mDl1c9A/OziIuGM78TFMXu2D/B4nhtRIwMzz2FR8vBsqa3gEL6Aps9FlzRSbCZ8IUBpa9094cvP5kEhblFTgXMBiSBYVpqSp/FPwIBUx1lH+6JV+ByPQODOVOLRVouLJutjiqRspxIjhIT+lCjcQ1lcT42WjEpL9pFK5VfIumJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242128; c=relaxed/simple; bh=0JyUXLy0yLTZ3s79eLGWtlsAqV4jjoK+wWXdiBezkyI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=H6XQfx+GVC4a7gYARKG++SgLzZQ54N6G3OXXHopTkcr+qxCzs0RulPjrM3lceS/BKCHK7AhfxySfR/SolSoBNR93T3DNxmBARtWoen7IN3+C1U24nQjieEaWAki5SvgeLtGvHtyjqcsLyDz2h9UCQrdFTct+BP9lxxiLhY0gvoA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I5HdLIRZ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I5HdLIRZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B0C31F000FF; Sat, 12 Sep 2026 19:42:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242126; bh=qjlKRK1pktPMLrb0CbyU390SRFmiTuVDKR97OGcqZqQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=I5HdLIRZW/djPdnxyCgfWCw1SqA0FN1dRbbnh3y0Cp8kNmo8igeBj038/BddLQae6 8bK3VjLyfiuWszqp6/gJx9VcazUUtky1KXKtIMLvvDxn2R2B45sAsEFkg/TeKQxJxa AMg4Vmv4IvuMan/r+MlZSraqbKAxTaiwx4zrSXWA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nilesh Javali , Hannes Reinecke , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.10 296/798] scsi: qla2xxx: Bound image count in qla2x00_update_fru_versions() Date: Sat, 12 Sep 2026 08:58:44 +0200 Message-ID: <20260912065523.947633360@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit de62cf265dbe309f34f144a6cdbca9240317727e upstream. qla2x00_update_fru_versions() copies the user-supplied BSG request into a fixed 256-byte stack buffer (bsg[DMA_POOL_SIZE]) and then iterates list->count times over the qla_image_version array embedded in that buffer, advancing the image pointer each iteration. count is taken directly from user input with no upper bound, while only (DMA_POOL_SIZE - sizeof(list->count)) / sizeof(struct qla_image_version) = 6 entries actually fit. A larger count walks the image pointer off the end of the stack buffer, reading adjacent kernel stack memory and sending it to the device via qla2x00_write_sfp(). Reject requests whose declared count does not fit in the buffer. Fixes: 697a4bc69159 ("[SCSI] qla2xxx: Provide method for updating I2C attached VPD.") Cc: stable@vger.kernel.org Signed-off-by: Nilesh Javali Reviewed-by: Hannes Reinecke Link: https://patch.msgid.link/20260723050413.3897522-56-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_bsg.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -1555,6 +1555,13 @@ qla2x00_update_fru_versions(struct bsg_j image = list->version; count = list->count; + + if (struct_size(list, version, count) > sizeof(bsg)) { + bsg_reply->reply_data.vendor_reply.vendor_rsp[0] = + EXT_STATUS_INVALID_PARAM; + goto dealloc; + } + while (count--) { memcpy(sfp, &image->field_info, sizeof(image->field_info)); rval = qla2x00_write_sfp(vha, sfp_dma, sfp,