From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F0F367B65; Sat, 12 Sep 2026 19:42:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242133; cv=none; b=WRWGazzgzAzhNpsDTEUaHWN/myjOJFiBnQgettFSC7A2HNmDVRQH3WXRYlLjgRRFFZxlLuf0dYKh1Lr6JltGROE8/v31K+A+XCwARXqolOSxi+P3XUqayVRMwUlRyrFAxACE5NMW/b77IKCK30oQQGRsJqfF1nxkoCVe47WNcL8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242133; c=relaxed/simple; bh=DRyaLEU3+wCkiz/08GyJYx6Dk8WL8JjOi7YdcrfntIw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ARxLvYa7MfJzFlXh2D0uadNLpnEL9dmYm64MhlyqnIOJ2EYaFFhep6f/134w9Nk6LFXsvZRAmFSM9JTTlzV83wPYup4n9kEhVoFGIXi7ub7ijPUgbjRoNXpSneZ7x7EBmeEXerSCXXsV7B/EsqAKQKFcGs9iLffA+NggwiN0z44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=qV7jFcLd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="qV7jFcLd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 076781F000FF; Sat, 12 Sep 2026 19:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242132; bh=ufI0evtnnyOpO41uICZOQ1r6wkzTzjmILm4EvSlDHrw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=qV7jFcLdFVX/STDeVjv1UBWCqocbOxZW9kStx+dQffn8uv6xWGuGpd/FYmq9NbAQX 7q+w6iMqlTwm6Dljp8W7cbRN7fAr+Xv0of23Zdsgoolm3nqdpe8xj9TvA2hQoe+KmF 1vaj50SiW6a1KgZaBozkxd/1w48vDsDMDdSJmWWg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Nilesh Javali , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.10 298/798] scsi: qla2xxx: Serialize flash version read in reset handler Date: Sat, 12 Sep 2026 08:58:46 +0200 Message-ID: <20260912065523.992710481@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit f606ed93de0c4f1e7e3618779e9fad731455314a upstream. The "update cache versions without reset" sysfs reset operation (0x20261) calls get_flash_version(), which reads hardware flash registers, without holding ha->optrom_mutex. The VPD update path serializes the same call under optrom_mutex, so this reset path can interleave its flash register accesses with a concurrent VPD or optrom flash operation and corrupt the reads. Hold ha->optrom_mutex across the get_flash_version() call to match the VPD update path. Fixes: 8c2cf7d4e387 ("[SCSI] qla2xxx: Add a new interface to update versions.") Reported-by: Sashiko Cc: stable@vger.kernel.org Signed-off-by: Nilesh Javali Link: https://patch.msgid.link/20260730155838.2119230-4-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_attr.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/scsi/qla2xxx/qla_attr.c +++ b/drivers/scsi/qla2xxx/qla_attr.c @@ -810,7 +810,9 @@ qla2x00_sysfs_write_reset(struct file *f "Unable to allocate memory for VPD information update.\n"); return -ENOMEM; } + mutex_lock(&ha->optrom_mutex); ha->isp_ops->get_flash_version(vha, tmp_data); + mutex_unlock(&ha->optrom_mutex); vfree(tmp_data); break; }