From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B9AF913D53C; Sat, 12 Sep 2026 19:43:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242190; cv=none; b=N5Vl3cn0ENx9egog3F7HtFMGKQV56Dd/sNEuFdiIDt1itPGR1Hc+PoyeJBmZT4mjxKplkJtBPNi2BOQkj4jFn1oMZUlv1/7zE13ll5gUMIB4itm2KmQ8ViFHLon7bt64+lZNJ5oAUnFZy8DooDI0aSmkofOW7bEryhOAwjDF4wA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242190; c=relaxed/simple; bh=Bt0zs4EcO9FkJbQsENEmsayIexgFujwQr8078Lkv4Vs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qm58eceVBHwOZAx/t4mZ+M9ES4Lenv73G/EamE3+g12dTzxrQzJgH2Yejwb9R2GZxCGDzpT9x5NfJOY0JKCax9vaa2dNsPaWSM630MSXFsw9WdD5Vh+HYXA70iic8Qg8ut/7/Ro5uBQgXWAWHBrwcLji+zrr3kmxU+7LIv36YJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=tyAFQ2V7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="tyAFQ2V7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF3811F000FF; Sat, 12 Sep 2026 19:43:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242189; bh=VoOLhiTdT5HlnkcS5rWD61FPS4Nz1xY4FK8fhc95wf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tyAFQ2V7rdtkh2Afqe/VQPy+wJLUBFPzHnUNZXfCwtp3tVeg2KhPVPqUCkU5zbCoq nM3mMHg0hCJPo2mRQAGXt3M88xJX4fTugF2vHSNF/nZlUtzPDjTSEuDvQ5n5g3rbg+ Ajv832wmdPIoW3Lv9M8ZDaS4K3S99SZqDQg7mBrc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Thomas Zimmermann , Yongbang Shi , Rongrong Zou , Sean Paul , Xinliang Liu , Dmitry Baryshkov , Baihan Li Subject: [PATCH 5.10 316/798] drm/hibmc: Fix list of formats on the primary plane Date: Sat, 12 Sep 2026 08:59:04 +0200 Message-ID: <20260912065524.401560568@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Thomas Zimmermann commit 0e682e136c466ae37c62f18099f591c096260ee0 upstream. Remove all formats from the primary plane that are unsupported for various reasons. * Formats with alpha channel: planes should not announce alpha channels unless they support transparency. There's no transparency support in the primary plane's implementation. * Formats with BGR order. The common format is in RGB channel order. There's no BGR support in the primary plane's implementation. * RGB888: atomic_update programs the format from cpp[0] * 8 / 16. For RGB888's cpp value of 3 this returns 1.5; rounded to 1. Programming the value of 1 to HIBMC_CRT_DISP_CTL_FORMAT sets up RGB565. Hence, the output is distorted. This can be tested by booting with video=1024x768-24. Removing all unsupported formats leaves XRGB8888 and RGB565. Both of which are supported and work correctly. Signed-off-by: Thomas Zimmermann Fixes: da52605eea8f ("drm/hisilicon/hibmc: Add support for display engine") Reviewed-by: Yongbang Shi Cc: Rongrong Zou Cc: Sean Paul Cc: Xinliang Liu Cc: Dmitry Baryshkov Cc: Yongbang Shi Cc: Baihan Li Cc: # v4.10+ Link: https://patch.msgid.link/20260618123142.92298-3-tzimmermann@suse.de Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c @@ -135,10 +135,8 @@ static void hibmc_plane_atomic_update(st } static const u32 channel_formats1[] = { - DRM_FORMAT_RGB565, DRM_FORMAT_BGR565, DRM_FORMAT_RGB888, - DRM_FORMAT_BGR888, DRM_FORMAT_XRGB8888, DRM_FORMAT_XBGR8888, - DRM_FORMAT_RGBA8888, DRM_FORMAT_BGRA8888, DRM_FORMAT_ARGB8888, - DRM_FORMAT_ABGR8888 + DRM_FORMAT_XRGB8888, + DRM_FORMAT_RGB565, }; static struct drm_plane_funcs hibmc_plane_funcs = {