From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9B0331203; Sat, 12 Sep 2026 19:48:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242497; cv=none; b=YqK6a1JGKJOGvxwEF3Hj34OhpFpSMekdNTVv7sKexLBSHhQjuvdoXCqr7KurJe5tlDYzzvzYnjouy2nY8L03Og2Sd/ehkngIF4VPFFTM6pS7D4q3YAG+uBRWVc2GR6geOWEJzhOLus13Ffd3PoDpjikL+EdCTjEKuiNImOEhmeA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242497; c=relaxed/simple; bh=LzYkHOHFetmM+THa5nepg03wE4XnGRqzfiGL5qM+YnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EhbFnx5Ix4DbOhr7+98Dvz6JqxuFJPsCXfqMgBsQIxbzjiU0jWgW0ZZtceaQWlvSyNv9W/HL39ItEueYLZy4FaEJBy+S7QX4EWkj8zrzJiwfLS9R/0NZH/KGFYh5z3B6GRGnLzUM1aqdp1Ugz8Ij3od3NUFxTFszyOBBF8sX1QU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kQY74Awo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kQY74Awo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41A4B1F000FF; Sat, 12 Sep 2026 19:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242495; bh=9bY9+Qi5RxOSwOwG5mnZY57m8QJ440xKIuqFu4wspbY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kQY74AwoMddDVQ7ZBotiN9VwmVvZKRN16fNAE91YCI/FLt/X/+lzxoA+E/w8P4KDq hRWxvCfHOzVGjq29uHZfmodlQzZ2wPm4HZs4RfE9SUspnr99JLTMDnFv/3p4gqtrNb QNcov6yeGc5QX6aq+5b4x1/clm3ZD+VF9jW9EYsU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ahmet Sezgin Duran , Sasha Levin Subject: [PATCH 5.10 382/798] staging: sm750fb: gate dualview dataflow using g_dualview Date: Sat, 12 Sep 2026 09:00:10 +0200 Message-ID: <20260912065525.909013459@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ahmet Sezgin Duran [ Upstream commit d352778979d2eed09e266ed0f3a5e3ccd3983940 ] In sm750fb_setup and sm750fb_set_drv functions, the dualview related code is guarded by `sm750_dev->fb_count > 1` condition. That value is updated only after each framebuffer is registered, while both guards are used before any increment. Current flow: lynxfb_pci_probe() sm750fb_setup() // fb_count is 0 for each fb: sm750fb_framebuffer_alloc() lynxfb_set_fbinfo() sm750fb_set_drv() // fb_count is 0 or 1 register_framebuffer() sm750_dev->fb_count++; // fb_count is incremented Thus even if `dualview=1` parameter is passed down to the driver, fb_count is never > 1 at either check, so dualview dataflows are not selected and crtc->vidmem_size is never halved. Use `g_dualview` global variable instead of fb_count > 1 to correctly enable dualview capabilities. Fixes: a3f92cc94c61 ("staging: sm750fb: replace dual member of sm750_dev with fb_count") Signed-off-by: Ahmet Sezgin Duran Link: https://patch.msgid.link/20260521204425.82627-1-ahmet@sezginduran.net Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/sm750fb/sm750.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 36eb7e5418998..6e3451d08e013 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -597,7 +597,7 @@ static int sm750fb_set_drv(struct lynxfb_par *par) crtc = &par->crtc; crtc->vidmem_size = sm750_dev->vidmem_size; - if (sm750_dev->fb_count > 1) + if (g_dualview) crtc->vidmem_size >>= 1; /* setup crtc and output member */ @@ -925,7 +925,7 @@ static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src) NO_PARAM: if (sm750_dev->revid != SM750LE_REVISION_ID) { - if (sm750_dev->fb_count > 1) { + if (g_dualview) { if (swap) sm750_dev->dataflow = sm750_dual_swap; else -- 2.53.0