From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3539526ED46; Sat, 12 Sep 2026 19:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242508; cv=none; b=VtP4gV03LZ5GP9LFq6kZISdAKOZ/65X77+hPKCBCRk3ifCAN0a+ECgHBGJzPQ1z90FqnMPIh8fIqhuZ7IAXb1izYr8aMsD3vyKBd64QaTPKFaFPovLn9GT46wzsYiVQTrVxH6NtCm++xkAalOrRQSRg9o3tvWFXqgL602Ui61Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242508; c=relaxed/simple; bh=59XQPRwFhJosIb9bmuApxMlh0kU0VhRAnrg4bQMqib0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ldLREyclA0x34M/pO7pd59A9BYEuwfZmGitakGRKIkTFpQTd4PA7QWimn0836TMbA9XKPMC3jRjeidgUHP+rTEJorBTnGit8H9ekFFaa1X117Ly38nNubyuyizqzJIv9oyHg3ipGz84FNsqAqeCpzUYUSUBwAAabBg7KmJjuvEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XCcT+72w; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XCcT+72w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E3E51F000FF; Sat, 12 Sep 2026 19:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242507; bh=0tZXOZYvqhqz3AWG6muLV5/YhFpNkXpQ/09VF719OZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XCcT+72w1mhk/q3k5ohamUagDxdir9qTMdDxfgt8IYBPeCIXvUBpoLzpcEJK33rjY MkOv4QQ2mkE8uIOd25j6VqqIu4OKV/+mq0nPCmDP5Vf3IGRitEbBf7Q1T7WqSR9oEk X8iq7DM6wPOFkVtj3viO0pE5xwkvSTRaUS96wMfk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuvraj Singh Chauhan , Sasha Levin Subject: [PATCH 5.10 386/798] staging: octeon: fix free_irq dev_id mismatch in cvm_oct_rx_shutdown Date: Sat, 12 Sep 2026 09:00:14 +0200 Message-ID: <20260912065525.997351004@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuvraj Singh Chauhan [ Upstream commit 41db5b76eeb4cc11a1097384caba7cfc659f7293 ] In cvm_oct_rx_initialize(), request_irq() is called with &oct_rx_group[i].napi as the dev_id: request_irq(oct_rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &oct_rx_group[i].napi); However, cvm_oct_rx_shutdown() passes cvm_oct_device (an array of struct net_device pointers) as the dev_id to free_irq(): free_irq(oct_rx_group[i].irq, cvm_oct_device); Since __free_irq() matches the action to remove by comparing dev_id pointers, the mismatched cookie means the IRQ handler is never found, triggering a WARN and leaving the IRQ line permanently allocated. This prevents proper driver cleanup on module removal. Fix the mismatch by passing &oct_rx_group[i].napi as the dev_id to free_irq(), matching what was used during request_irq(). Signed-off-by: Yuvraj Singh Chauhan Link: https://patch.msgid.link/20260212171903.1417804-1-ysinghcin@gmail.com Signed-off-by: Greg Kroah-Hartman Stable-dep-of: c0a9a8586a63 ("staging: octeon: add missing napi_disable in cvm_oct_rx_shutdown") Signed-off-by: Sasha Levin --- drivers/staging/octeon/ethernet-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 9ebd665e5d427..2618ba9898c31 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -535,7 +535,7 @@ void cvm_oct_rx_shutdown(void) cvmx_write_csr(CVMX_POW_WQ_INT_THRX(i), 0); /* Free the interrupt handler */ - free_irq(oct_rx_group[i].irq, cvm_oct_device); + free_irq(oct_rx_group[i].irq, &oct_rx_group[i].napi); netif_napi_del(&oct_rx_group[i].napi); } -- 2.53.0