From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F14026ED46; Sat, 12 Sep 2026 19:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242392; cv=none; b=X5Yh99ouG4ynkOc3v+TrClF8Rk7VnjIvnbrU+9Cb+QCNrp5jsaR9Bp4bJHVzvyp3HOM9uH3dQanl7iFgF6shA/x+sTJTLYJn8G+1aLR8NOU7jy4KWwe751CdzVk/wotlZLM4cHLvsJbndWrsGvfr2fcIJmScOMlxnpkAEObMPR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242392; c=relaxed/simple; bh=D0wZiWFhvZEe0rcoks/mVyFXE1joC7gob9o26aPK+KQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=l1scRmiBj+IVdqWqIwOoxwyDWfqWKi4MGZObHU9VH3Gm3nhNz3UB4alRsIUjZGUw33go/ZSXh888s8ge216f6ttWXRvdYOkfOhaTQK5KbEhlM+Nkuy9bLmR+k3/umwq0rCZRMNtT3u1Ck0f+rPRzi5N0Ndgy5DNnbOBaL28qwTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=N5PeumqK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="N5PeumqK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3B211F000FF; Sat, 12 Sep 2026 19:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242391; bh=w37WfL9c8x6TTh0LWT6B76LauFLsNgKrJQB27ILYFFM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=N5PeumqK1MKLFEsgyO77P02y2kkTntDVFIr7NN7Mwl4pK1wYplk+FisRc2X1yOHyG IAumyYSLKxmaTXpN0iTCz4ojtzx2CfzcynASOAO/gSfGhd8WMNpjfCCOV5OK9COGF5 kx/K/QIW7YDwzfsS9xyrEKiTxls7jbtspju1XM3s= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zilin Guan , Dawei Feng , Dan Carpenter , Sasha Levin Subject: [PATCH 5.10 388/798] staging: rtl8723bs: fix mismatched free of HalData in rtw_sdio_if1_init() Date: Sat, 12 Sep 2026 09:00:16 +0200 Message-ID: <20260912065526.044897980@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dawei Feng [ Upstream commit 264676418b726baca7be49171e306b6aa05cceb0 ] padapter->HalData is allocated via vzalloc(), but incorrectly freed using kfree() in the rtw_sdio_if1_init() error path. Using kfree() to release this vmalloc-backed buffer can lead to memory corruption. Use rtw_hal_data_deinit() to pair the free correctly and free HalData with vfree(). The bug was first flagged by an experimental static analysis tool we are developing for kernel memory-management bugs. Manual inspection confirms that the issue is still present in current mainline. An x86_64 allyesconfig build showed no new warnings. As we do not have suitable RTL8723BS SDIO hardware to test with, no runtime testing was able to be performed. Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by: Zilin Guan Signed-off-by: Dawei Feng Reviewed-by: Dan Carpenter Link: https://patch.msgid.link/20260525091836.812565-1-dawei.feng@seu.edu.cn Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index b2208e5f190ad..6c088586cdf34 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -394,8 +394,8 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct status = _SUCCESS; free_hal_data: - if (status != _SUCCESS && padapter->HalData) - kfree(padapter->HalData); + if (status != _SUCCESS) + rtw_hal_data_deinit(padapter); if (status != _SUCCESS) { rtw_wdev_unregister(padapter->rtw_wdev); -- 2.53.0