From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0222636828B; Sat, 12 Sep 2026 19:46:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242398; cv=none; b=mXeTLWjAgVRvQ3Q4C+f7jUHEPhtoRPpIGXUQgEyVV+6yf8l8pIAMuz/TAGtLqRrGYLxt0TdZVNoY/917/nCnTuMqUfuyE9rsMLvgRd9DMD1D9gNLb8mTDrxOh18OWagWKpmNJ8e4QHwq+nnARNy5c1dgBXW8gnvchyh/0K3XkE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242398; c=relaxed/simple; bh=81trmishS9h3Zj6ZIshQmm3jsqemsNfyXjqPF36U8ic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jbJGg0AF3IG2JLmUW+hTh1hFWqv/0vh5c2Mahq6e2YH+XNXtTsXBS3TAyJsdg4wS3oOAp47PGAG0nUVbPGZrI1R3h58AT9XDyQoOd/JqddLFI1yJ77Vk2NFjaxrvhQ2Zwx5aOb/r//S/1uO5HSZvn/jLX9w2EzPjLkciB9YkP5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0DkHGo/W; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0DkHGo/W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D85F1F000FF; Sat, 12 Sep 2026 19:46:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242396; bh=bSCTlT/Qck2G3UyBL+/9ryI+nh05cso7dtgs2XHXUoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0DkHGo/WggDjDNd30LXhK6DZu1eU0j8Qv9GZprUzFHLDmlM9NxK32hWSw9YyVIMXv jv2k6YZgXSejNuApss/CQP0p2dTg9aTrNWEptbB5riGhvqblmix0n6PC8gJeLGJZf5 N0Z0maETsvPjHm45ZSV7s81OOjtNWzOoCUTCxaLI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Malaya Kumar Rout , Emil Tsalapatis , Kumar Kartikeya Dwivedi , Sasha Levin Subject: [PATCH 5.10 390/798] selftests/bpf: Fix memory leak in msg_alloc_iov error path Date: Sat, 12 Sep 2026 09:00:18 +0200 Message-ID: <20260912065526.087954548@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Malaya Kumar Rout [ Upstream commit 0bebfaa39deadec21638f6fba553eae12627a26d ] In msg_alloc_iov(), when calloc() fails for an individual iov_base allocation, the error path frees all previously allocated iov_base entries but fails to free the iov array itself that was allocated with calloc() at the beginning of the function. This results in a memory leak of the iov array. Add free(iov) in the unwind_iov error path to ensure proper cleanup of all allocated memory. Fixes: 753fb2ee0934 ("bpf: sockmap, add msg_peek tests to test_sockmap") Signed-off-by: Malaya Kumar Rout Reviewed-by: Emil Tsalapatis Link: https://lore.kernel.org/bpf/20260704122936.102394-1-malayarout91@gmail.com Signed-off-by: Kumar Kartikeya Dwivedi Signed-off-by: Sasha Levin --- tools/testing/selftests/bpf/test_sockmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/bpf/test_sockmap.c b/tools/testing/selftests/bpf/test_sockmap.c index 5b4390d643b21..906a2e22957d5 100644 --- a/tools/testing/selftests/bpf/test_sockmap.c +++ b/tools/testing/selftests/bpf/test_sockmap.c @@ -515,6 +515,7 @@ static int msg_alloc_iov(struct msghdr *msg, unwind_iov: for (i--; i >= 0 ; i--) free(msg->msg_iov[i].iov_base); + free(iov); return -ENOMEM; } -- 2.53.0