From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94D5D331203; Sat, 12 Sep 2026 19:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242519; cv=none; b=TocCio2gNwfZOVYLsrZUimyloUpWgFzJarHg9j5kf4Bl5LNnWQctsIlxRoCi859qjrAOPrjWMpM0VkmmYSStqQsE88Rw0Z9lYlqC351+lmhzmqGIsiTIApROiFdgOeIhkdnQ2UupDhtdQhAlCppAw+rRaH2KpHzBisFrQIolkk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242519; c=relaxed/simple; bh=y7UY8RxmjlA1wNrI4xfvV3LHKiV9JK70BU28hS+uiaI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k7I4JPbO1q0o7IfZAqdNnBJqXCTrZ1m7Ny3Pfnp/pCkphscbT/AFdXFGh9TL1rpdCH9PLoqLBWSnZUcRGMKR/Oikwqb1iduE8VRIg6YVTIcN61/f46z2jeBH2iszpeCpHwufAscR/6jIA7VZWaiksnFrdL3rPjPBlVaUwO2kL54= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0sM+uWSS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0sM+uWSS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F019C1F000FF; Sat, 12 Sep 2026 19:48:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242518; bh=NXphnHB/rXrSKtNGU+WPlehcrkrvAOuYScxwKZCaKTk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0sM+uWSSqqpHML81UzbG8ixPdeCiBtIqhQF9hXC2Nuo3lhCVabiHAHkfEfSv75lIJ 2uCmTkx2/LrPp1pRKo7luA857rUr1EWEFPopxsKzQsfmAKwOl5UDGo3RJvOM73f1Rw 2WArY9TcUEsraqzdxYsgzT3WShZA2QLRYOH+1zJM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Leon Romanovsky , Sasha Levin Subject: [PATCH 5.10 433/798] RDMA/hfi1: Stop flushing the global IB workqueue Date: Sat, 12 Sep 2026 09:01:01 +0200 Message-ID: <20260912065527.069554203@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Leon Romanovsky [ Upstream commit d43b1c17f9e1b9d34a0d742f569c00d84147ebc0 ] hfi1 does not queue work on ib_wq. QSFP and link work run on the per-port link_wq, while the remaining device work uses hfi1_wq or dedicated queues. The probe failure path destroys both per-port workqueues, and normal device removal flushes them in shutdown_device() before destroying them. Remove the flushes of the core-owned global workqueue. Waiting for unrelated core or other device work is not part of hfi1 teardown. Fixes: 71d47008ca1b ("IB/hfi1: Create workqueue for link events") Link: https://patch.msgid.link/20260708-clean-init-one-hfi1-v1-10-b9e9641268a5@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/init.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c index 05c3f48bbf9a6..d130465dcfa1b 100644 --- a/drivers/infiniband/hw/hfi1/init.c +++ b/drivers/infiniband/hw/hfi1/init.c @@ -1692,7 +1692,6 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) if (initfail || ret) { msix_clean_up_interrupts(dd); stop_timers(dd); - flush_workqueue(ib_wq); for (pidx = 0; pidx < dd->num_pports; ++pidx) { hfi1_quiet_serdes(dd->pport + pidx); ppd = dd->pport + pidx; @@ -1768,9 +1767,6 @@ static void remove_one(struct pci_dev *pdev) stop_timers(dd); - /* wait until all of our (qsfp) queue_work() calls complete */ - flush_workqueue(ib_wq); - postinit_cleanup(dd); } -- 2.53.0