From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD20A38E8CB; Sat, 12 Sep 2026 19:50:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242601; cv=none; b=Y2AwDvTZNZlbpyKENh8AyswImHqE4tL6W1MrlYgBX6sztZd1+JzX7KfE9FlFiFNQKYpFNj343DCejfESI/s11HDpjsxua1xDdMKvGnuJHrekiZR+tIjQC+kAS93267JFGbNSrnArSl1sRvXizUrXpxmmP8ZIC14TKTnIRYzaPUI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242601; c=relaxed/simple; bh=QFaCIWT6L376ufTr5VclD5z6TZEnDL1maL9VoFB7+yQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HL/1p9D5XtHJXWPR1YynlNl4AqeAOTgWiG+bm0wh7cHOPTnRJPcp/aiEW2ZeIPIX5QLFQ2Pa/a2xciKOvM+cENUqNvyqUShDMnGWfRBWXqg0+V9K5d68cu5KH3lMNodSFuUzIXL/SiyMI0rXHW95XFl4Od0ieS6H+gat7urYIX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0l3/u9wE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0l3/u9wE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31CF71F000FF; Sat, 12 Sep 2026 19:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242600; bh=YJpmpraO9PQbv6RLZ41AZ+dHHyXxSDgzuyoBndeWs1M=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=0l3/u9wEoIxkUFEUv9fc98jPbUaWpdFA09maQGTM3vluNXsxiqABS2FXdyQuKhTrZ ukdRb/SCyywBnpLwMCCZEDkggMRs0mDoWC7XwTxPJa8iHkDX1WMtSFZIb8fDGzSRFe 6um4FedCZ9a6s6XThu88TMKzyA7zA47u/T0q10O0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Christophe JAILLET , Samuel Thibault , Dan Carpenter , Sasha Levin Subject: [PATCH 5.10 460/798] accessibility: speakup: Fix incorrect string length computation in report_char_chartab_status() Date: Sat, 12 Sep 2026 09:01:28 +0200 Message-ID: <20260912065527.689504676@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Christophe JAILLET [ Upstream commit bce0e640623372520d9d90c42f33ddbfb576ce69 ] snprintf() returns the "number of characters which *would* be generated for the given input", not the size *really* generated. In order to avoid too large values for 'len' (and potential negative values for "sizeof(buf) - (len - 1)") use scnprintf() instead of snprintf(). Fixes: c6e3fd22cd53 ("Staging: add speakup to the staging directory") Signed-off-by: Christophe JAILLET Signed-off-by: Samuel Thibault Reviewed-by: Samuel Thibault Reviewed-by: Dan Carpenter Link: https://patch.msgid.link/20260531230804.254962-5-samuel.thibault@ens-lyon.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/accessibility/speakup/kobjects.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/accessibility/speakup/kobjects.c b/drivers/accessibility/speakup/kobjects.c index 41ae24ab5d086..917cdbf671842 100644 --- a/drivers/accessibility/speakup/kobjects.c +++ b/drivers/accessibility/speakup/kobjects.c @@ -92,9 +92,9 @@ static void report_char_chartab_status(int reset, int received, int used, if (reset) { pr_info("%s reset to defaults\n", object_type[do_characters]); } else if (received) { - len = snprintf(buf, sizeof(buf), - " updated %d of %d %s\n", - used, received, object_type[do_characters]); + len = scnprintf(buf, sizeof(buf), + " updated %d of %d %s\n", + used, received, object_type[do_characters]); if (rejected) snprintf(buf + (len - 1), sizeof(buf) - (len - 1), " with %d reject%s\n", -- 2.53.0