From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C15A3451C8; Sat, 12 Sep 2026 19:50:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242653; cv=none; b=Atn1MSGZZ6meEBoaHDhQngzVjlRn3E/GIHxyFrP6uUwjgp8DxgItSEniYLBySpQ1/NHDNH0y55MGd5lg7CY31Pqk4CXkSJ1SEU9Z4zPFusN5P6JjOYXDMapHEwyGmA9izcxOpcWMfrbZfm2E2/pXFZU1IDiFCaGQ+X0iP1H9dQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242653; c=relaxed/simple; bh=twda9wWiQf8+4UV10f9yrcxf1DNOnAh3YtdZOV7MErA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HgFEsTIQNr8/8osha/OCKu5UIACz+7/yEJ+D5oOuNnyyj2IZszvaMT2I2/tqzz2Hh/vjF1NH+ERGOqfUlLYFgU//LQ1o94mUAYBQe6iOUNclDkmwO9XRyZFlgD/jzzeXrqsDAz/YzGkJcX3gNTIHdNek6MEbIgLCNAAK37bKEWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ft29mTmf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ft29mTmf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CFD41F000FF; Sat, 12 Sep 2026 19:50:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242651; bh=Mt2ZOML94aAU7x9EtrIL12DbvRkiyECSnlcjlvRx16Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ft29mTmfJDRMjqkidHGr3y6Ct0WwEDBYgtSAbb7VDFykLMJ4PLEBWUC99fwH/Blvu z+hKAhcc019Q1Je+h9zdYDmMwIvO3ozCxjbEvlxWaWKdOeZgm29RHE3n5bjLUA5mkL F4PfBmPeL3hpbX/JTKiBozaaPNdxt4NIFYgdJbKI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Danila Chernetsov , Leon Romanovsky , Sasha Levin Subject: [PATCH 5.10 480/798] RDMA/hfi1: Propagate sdma_txinit_ahg() errors Date: Sat, 12 Sep 2026 09:01:48 +0200 Message-ID: <20260912065528.143886377@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Danila Chernetsov [ Upstream commit 091c6162c022cbdfb64219708a71728cfd1d4600 ] set_txreq_header_ahg() ignores the return value of sdma_txinit_ahg(). If sdma_txinit_ahg() fails, it returns before initializing tx->txreq. However, set_txreq_header_ahg() ignores the error and returns the AHG change count, causing the caller to continue processing the request as though initialization had succeeded. Propagate sdma_txinit_ahg() failures to the caller and abort request processing when initialization fails. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: e3304b7cc4f1 ("IB/hfi1: Optimize cachelines for user SDMA request structure") Signed-off-by: Danila Chernetsov Link: https://patch.msgid.link/20260708162252.936634-1-listdansp@mail.ru Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/user_sdma.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/hfi1/user_sdma.c b/drivers/infiniband/hw/hfi1/user_sdma.c index a67791187d46d..7b8519ff16c95 100644 --- a/drivers/infiniband/hw/hfi1/user_sdma.c +++ b/drivers/infiniband/hw/hfi1/user_sdma.c @@ -1100,6 +1100,7 @@ static int set_txreq_header_ahg(struct user_sdma_request *req, struct user_sdma_txreq *tx, u32 datalen) { u32 ahg[AHG_KDETH_ARRAY_SIZE]; + int ret; int idx = 0; u8 omfactor; /* KDETH.OM */ struct hfi1_user_sdma_pkt_q *pq = req->pq; @@ -1204,11 +1205,13 @@ static int set_txreq_header_ahg(struct user_sdma_request *req, trace_hfi1_sdma_user_header_ahg(pq->dd, pq->ctxt, pq->subctxt, req->info.comp_idx, req->sde->this_idx, req->ahg_idx, ahg, idx, tidval); - sdma_txinit_ahg(&tx->txreq, - SDMA_TXREQ_F_USE_AHG, - datalen, req->ahg_idx, idx, - ahg, sizeof(req->hdr), - user_sdma_txreq_cb); + ret = sdma_txinit_ahg(&tx->txreq, + SDMA_TXREQ_F_USE_AHG, + datalen, req->ahg_idx, idx, + ahg, sizeof(req->hdr), + user_sdma_txreq_cb); + if (ret) + return ret; return idx; } -- 2.53.0