From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 202001FBEA6; Sat, 12 Sep 2026 19:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242704; cv=none; b=UIpo2luk/jllVKs7bFsMsqQQf7x0pBUvo4Jo72cn1Otqig5O5lhdj6HU2b/frlUeK/O8wkPXCG3mRaOuHRoq72/8T/HhiF6pgdGzMCasmXdFrBhZGdLNED5jMvucqD7/iHtVaCZ/Dywcii+L+A5ZyC2Hvj2BxSuh7xx8jJ2Gwks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242704; c=relaxed/simple; bh=TlJiUyBFzxWzYmzc6v4+v7KorZhCUk0N95CjI3J4BVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lu4XlPsR8i78mcqFafNMl2CFoHmQzkhTGzAMOuek1lRlHjJLJatLxiiYr+pGbgqpgCgqgU3CVYkpp/ydOiSGki54W1kSL368h0acm38ew3XXWxNdDELC38G5KK/cmsYBuNTt/nIfDtnsKTzaMYMTb6nuS5gickdyvSwwyT46xJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eDU5WCFB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eDU5WCFB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C73B1F000FF; Sat, 12 Sep 2026 19:51:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242703; bh=/H/HKfzYZpIYLj/pKSeHIJZlKXUxHX3KzADCYUmiw20=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eDU5WCFB7SwMWj1uYyI2M6q9YMU601ZtazoZGp8QwdHEYuuEpUwjcqiG35j/mWimE /pScPbmkl1oRvzal/OOz6fwTicYYEUx3gBzIT4cqUhTaCoWNxsqRtR4dt/wN16NbER e664AKDheonn6P+nd2BhNtxR6sN0CjCTb0PKb0j8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Konrad Dybcio , Mukesh Ojha , Will Deacon , Sasha Levin Subject: [PATCH 5.10 497/798] iommu/qcom: Fix inverted fault report check in qcom_iommu_fault() Date: Sat, 12 Sep 2026 09:02:05 +0200 Message-ID: <20260912065528.527821779@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mukesh Ojha [ Upstream commit 1f33b8208a1978b0c0d6ad60a47fe4bb7a235e58 ] report_iommu_fault() returns 0 when a fault handler successfully handles the fault, and -ENOSYS when no handler is installed. The condition '!report_iommu_fault()' evaluates to true (printing "Unhandled context fault") precisely when the fault *was* handled, and stays silent when no handler is present — the opposite of what is intended. Remove the '!' so the driver logs unhandled faults correctly. Fixes: 049541e178d5 ("iommu: qcom: wire up fault handler") Reviewed-by: Konrad Dybcio Signed-off-by: Mukesh Ojha Signed-off-by: Will Deacon Signed-off-by: Sasha Levin --- drivers/iommu/arm/arm-smmu/qcom_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c index 4154a85fcf07d..f59b53805dd03 100644 --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c @@ -220,7 +220,7 @@ static irqreturn_t qcom_iommu_fault(int irq, void *dev) fsynr = iommu_readl(ctx, ARM_SMMU_CB_FSYNR0); iova = iommu_readq(ctx, ARM_SMMU_CB_FAR); - if (!report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { + if (report_iommu_fault(ctx->domain, ctx->dev, iova, 0)) { dev_err_ratelimited(ctx->dev, "Unhandled context fault: fsr=0x%x, " "iova=0x%016llx, fsynr=0x%x, cb=%d\n", -- 2.53.0