From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2727345EB5; Sat, 12 Sep 2026 19:52:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242726; cv=none; b=KBRf8gU9Dpi8tw7aCMYMw7r3w9S4z5rbV222CuaVOnDOANfMqSK0gJiVZPzO4xYVaPyez1RjM9EqfsNBlYzTJwgWh1fqx36RUSNRU5HunYPX21XEiR8WZc2ukE3QuswEzqb/9zOjkG6Fa24M4wWRtM8XqkIm+BKsehoANHlSIVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242726; c=relaxed/simple; bh=Qhk1gXv31Xw+cxmofVkp5sS8p6GFIR1d2+UQw7ZsWYo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QHMZX3YIexUUIcKIEjsou8U1xtrH8eal4pUbYM7D/UEnx27tOGPgXgeZBflznx5v/EGitM71me86SNLOdwyHnrpwRwj8GazD9kSbm5JJ3YP9Kw4H8Y2JTmfzBBq4t7Fx/NLHvn12fN/SLqeMVamSviPzRnvkkGnpvbPPbwOH9Fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eiceU9Dv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eiceU9Dv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3717F1F000FF; Sat, 12 Sep 2026 19:52:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242725; bh=Oftux3xf22rKMptfLTk+zUGeyKOOQ6BbkZWipnQkfRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eiceU9Dv4wimL1ruaxahF+wSFdoAu7/OEmg+qvbo142BuAVnzqatdDPbhvDl7AX2Z 32xS5qgHz9lU7ydp4tR3sHFetG76L7bx+GUOTUYnFyzmydg+gZO+PGfSPHBbWYxBXy z6EZKHG5UvjZkxHIRMkHGAv6m5Hmfdo6xRx4zMKQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Rameshkumar Sundaram , Baochen Qiang , Jeff Johnson , Sasha Levin Subject: [PATCH 5.10 504/798] wifi: ath11k: Avoid buffer overread in ath11k_wmi_tlv_op_rx() Date: Sat, 12 Sep 2026 09:02:12 +0200 Message-ID: <20260912065528.686436918@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeff Johnson [ Upstream commit 9ef9dd30058cc9223c72f711dca1a28a5947d0c5 ] Currently, in ath11k_wmi_tlv_op_rx(), the firmware buffer is read without first verifying that the buffer has enough data to hold a header. This could result in a buffer overread. Add an upfront length check before dereferencing skb->data as a wmi_cmd_hdr. The check is placed before the trace_ath11k_wmi_event() call to preserve the existing trace semantics (tracing the full raw WMI event including the header), unlike the analogous ath12k fix which could use skb_pull_data() directly. Compile tested only. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Assisted-by: Claude:claude-sonnet-4-6 Reviewed-by: Rameshkumar Sundaram Reviewed-by: Baochen Qiang Link: https://patch.msgid.link/20260716-ath11k_wmi_tlv_op_rx-overread-v1-1-0b972b3f1368@oss.qualcomm.com Signed-off-by: Jeff Johnson Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/ath11k/wmi.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index ec82f4c8c955f..fad0a4a4a0240 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -6428,13 +6428,15 @@ static void ath11k_wmi_tlv_op_rx(struct ath11k_base *ab, struct sk_buff *skb) struct wmi_cmd_hdr *cmd_hdr; enum wmi_tlv_event_id id; + if (skb->len < sizeof(*cmd_hdr)) + goto out; + cmd_hdr = (struct wmi_cmd_hdr *)skb->data; id = FIELD_GET(WMI_CMD_HDR_CMD_ID, (cmd_hdr->cmd_id)); trace_ath11k_wmi_event(ab, id, skb->data, skb->len); - if (skb_pull(skb, sizeof(struct wmi_cmd_hdr)) == NULL) - goto out; + skb_pull(skb, sizeof(*cmd_hdr)); switch (id) { /* Process all the WMI events here */ -- 2.53.0