From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8174F38F620; Sat, 12 Sep 2026 19:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242800; cv=none; b=Zj8wC7rqBnAJYyX0nHK1j/Hf1BVy4iyU3I8jQRsFRAc+boqOYktzkfxnetdGExKdlpu5hVtcRpNDA130CGGTLM/GwTqcWv0r7RhaiBpv56zOfaS4DA/fopZTfGGJ4BGIaUcXRDCmaCXZaPiPDs27rw8xGWvQVPazWhK9i1RYgz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242800; c=relaxed/simple; bh=kzjD3NYnQ4KswV32JvblvsIkoi6FbpV/OykyuCDd12o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=L+9fwOBTu7WCYNl0RU+qvQcJl3ioMbygwNi66/PkQyWeiIQ3kcVKvmFrqkzCeq1mRtt+yJ4zmc2VeGpXt6Igd7ISdSk0sqNhAmzf+k7y/PEYU4rzXH2BSNsbUE+4URaAh9X6S7vDr2oHH1uHACYXdQwwVWEC13DNEVJ7qmwuE5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=awi4g4rw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="awi4g4rw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE3411F000FF; Sat, 12 Sep 2026 19:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242799; bh=ng15pfJUrIwze7lJPAafPb/7/GbR59R2XEtfWgaCwVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=awi4g4rwlI7JKAKm4Qm4WITCG2WUUzGktFFpjbDpGC5oQJUxKpxK0pJYhBtSQkD7K E3L/FYVdBhsdYYbA/Wvk3ZQlN7KeB8or+eQ3/WPwe7omdiJGXtpBkT8AfWWscH+kFT tskG14QjPxpz4TEUuQrSuY18ZLJt9o22p9qiZIbc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+cae54346a70bbceeff2c@syzkaller.appspotmail.com, Joshua Crofts , Ryusuke Konishi , Viacheslav Dubeyko , Sasha Levin Subject: [PATCH 5.10 532/798] nilfs2: fix infinite loop in nilfs_clean_segments() Date: Sat, 12 Sep 2026 09:02:40 +0200 Message-ID: <20260912065529.324368233@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joshua Crofts [ Upstream commit ce5a5ad1a8330a2fcfdd9ec2ab341be739e89a18 ] syzbot reported a hung task in nilfs_transaction_begin(). This occurs because the cleaner ioctl falls into an infinite loop if nilfs_segctor_construct() repeatedly returns -EROFS (e.g. the device is remounted as read-only after an I/O error). Currently in nilfs_clean_segments(), if err is non-zero, it logs the error and sleeps but doesn't abort when it encounters a terminal error like -EROFS. This causes the thread to loop forever. Fix this by breaking out of the loop if nilfs_segctor_construct() returns -EROFS. This matches the behaviour in nilfs_segctor_write_out(), which also handles -EROFS. Reported-by: syzbot+cae54346a70bbceeff2c@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=cae54346a70bbceeff2c Fixes: 9ff05123e3bf ("nilfs2: segment constructor") Assisted-by: gemini:gemini-3.1-pro Signed-off-by: Joshua Crofts Acked-by: Ryusuke Konishi Signed-off-by: Viacheslav Dubeyko Signed-off-by: Sasha Levin --- fs/nilfs2/segment.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index a7600e6722ef4..18964331ee3d9 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2554,6 +2554,10 @@ int nilfs_clean_segments(struct super_block *sb, struct nilfs_argv *argv, break; nilfs_warn(sb, "error %d cleaning segments", err); + + if (unlikely(err == -EROFS)) + goto out_unlock; + set_current_state(TASK_INTERRUPTIBLE); schedule_timeout(sci->sc_interval); } -- 2.53.0