From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 417E5390981; Sat, 12 Sep 2026 19:55:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242957; cv=none; b=a9NBLaDZkBfa/ZG7RvGqBqSVPMfGPOKW2aKYe34pvs4bwevYu1PcmfRGBCyINXIPJ05heizL1uAb6tt3ozhQ52ShmxxF9dyqqb81GO6k6lbRsEZHkAEnMHCpzrVBAwgstRy6L1XWQ2JGLPfRiu4OhgkN6x/VjtxrlNF9BZZkz54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242957; c=relaxed/simple; bh=zzRaPZWSAc5sChn4DRdv7UxpJzDQxf3wRSJqmdXm6tA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q+4sl/k6r9DIpfjG7S+32Q3fqT9zGtTwRRjpgyeFOiAqomRAPOYlKCQdZAdy1/BNTisX4T3349xno1RwOC3uoVLlrbQeH59SKQKCsyX6enw+XZU3QvoVe1+nIqmzkIYavgEhYTkjTFwC86u+5gcEiTrNHJqaxVLBd9F2Go2pCeQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yZDB+oLf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yZDB+oLf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A4DD1F000FF; Sat, 12 Sep 2026 19:55:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242956; bh=ftoveqRXAKkFjvFrtpjGHTq5zanya9PuVItW8hdqDHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yZDB+oLff4bcBpOpmeLfqsvlJahXSMgnlR25DcC1V4BI0QDgHyy2TIYb6q0cvn2ou U1GSEzBXf3MdzPgx9G7uvJNACVAE8XmUwAJM2/LjMs8EPn2k8fQjZ1o5YkQqj409ib C+X7EO3ccyjpOePPUL30hYYbiSxtd+xWZ3k0HmPc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Konrad Dybcio , Dmitry Baryshkov , Sasha Levin Subject: [PATCH 5.10 559/798] drm/msm/dsi: Drop dev_pm_opp_set_rate(0) Date: Sat, 12 Sep 2026 09:03:07 +0200 Message-ID: <20260912065529.941309220@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Konrad Dybcio [ Upstream commit 06b7ba206561619bb34116f49e0ef26b867ce3aa ] dev_pm_opp_set_rate(0) removes the vote specified in required-opps but does not actually park the clock, making it run without the necessary power backing. Drop the explicit call to it. Every call site of ops->link_clk_disable() is followed by pm_runtime_put(), so the power vote will be rescinded if deemed safe. Fixes: 32d3e0feccfe ("drm/msm: dsi: Use OPP API to set clk/perf state") Signed-off-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Patchwork: https://patchwork.freedesktop.org/patch/742783/ Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-3-e7783b859a70@oss.qualcomm.com Signed-off-by: Dmitry Baryshkov Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index b69099b533bfe..c389bea8c7f38 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -663,8 +663,6 @@ int dsi_link_clk_enable_v2(struct msm_dsi_host *msm_host) void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host) { - /* Drop the performance state vote */ - dev_pm_opp_set_rate(&msm_host->pdev->dev, 0); clk_disable_unprepare(msm_host->esc_clk); clk_disable_unprepare(msm_host->pixel_clk); if (msm_host->byte_intf_clk) -- 2.53.0