From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE127367B65; Sat, 12 Sep 2026 19:56:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243020; cv=none; b=BAGmIqUIu/Il0Ogyi1/HT+DnCIGoR1sSBxPPWjGBzAw+npD3b/Xbt/ishsnTAjfT0ojDRoLqTj1Uvr+j8RVOidgtQZ6K4bgV3Xnus3x8fGgxQReWXFCtFxmDWPwEnTF9xqu8Wcc4TWUQrohTIH+v75dqMxpy82GsL+EKdjVtlf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243020; c=relaxed/simple; bh=EY2JN1W7P7SBaFGT3DJS9EKIhcY6I9+NWBQvG+cKAxA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k7MIX9Tk/weIzY49rdnvhKpesWkOjIr66kEEOCkv1Irme1+DTr3SCLwIaxIwPhKmILOBwiH22XySnePc18obKQT1qYHAoq1N9PbLeVZXMoOsoxSrttaBPJC8t9j9JxolnKi7VImVjmlrbHHVvhrDwwC0IWVVkAVnT8Xcf52y+6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=PcOcppiH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="PcOcppiH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1334D1F000FF; Sat, 12 Sep 2026 19:56:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243018; bh=QD1xPXjA9h+mGY7oIVeiEeDVs1gL/54RV/AYpdeBzyk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=PcOcppiHCIGjLDaBktfU5Lu3S9oTT5oeEhLnTcmG63p41dmODsEak0/DkIKcXcvpc HQYzXtXL8hUFk7wGu3pjQXGmj8wkeoYKvcAfQ9UDBsgGVixJtEVgn2IEb4+s8jMD0M sZFGeplutF6ftIeOif4yQ09/rG70HkKOFRm8P5h0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , "Zhang, Yanmin" , Arnaldo Carvalho de Melo , Namhyung Kim , Sasha Levin Subject: [PATCH 5.10 565/798] perf machine: Dont abort guest map creation on first inaccessible dir Date: Sat, 12 Sep 2026 09:03:13 +0200 Message-ID: <20260912065530.078508634@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Arnaldo Carvalho de Melo [ Upstream commit b687e1a418fb819ef83c362d84c216a6a841e3b0 ] machines__create_guest_kernel_maps() jumps to the failure label when one guest directory's kallsyms file fails access(), skipping all remaining valid guest directories. An inaccessible directory is not fatal — other guests may still be reachable. Replace 'goto failure' with 'continue' so the loop processes all directories, and remove the now-unreferenced failure label. Fixes: a1645ce12adb ("perf: 'perf kvm' tool for monitoring guest performance from host") Reported-by: sashiko-bot Cc: Zhang, Yanmin Assisted-by: Claude:claude-opus-4.6 Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim Signed-off-by: Sasha Levin --- tools/perf/util/machine.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index be18fd39813f6..197d68d533b1b 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1240,14 +1240,12 @@ int machines__create_guest_kernel_maps(struct machines *machines) snprintf(path, sizeof(path), "%s/%s/proc/kallsyms", symbol_conf.guestmount, namelist[i]->d_name); - ret = access(path, R_OK); - if (ret) { + if (access(path, R_OK)) { pr_debug("Can't access file %s\n", path); - goto failure; + continue; } machines__create_kernel_maps(machines, pid); } -failure: free(namelist); } -- 2.53.0