From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6182B38F92F; Sat, 12 Sep 2026 19:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242934; cv=none; b=ApP+A5Ie9ZmLJxIkg8DYZxceN1XyvN/PKW4QOPNJvL79z/UNl+kPkHSca3wtklHOEhvmrFAWmhraWoUaH1lfD/B1CkWTKLMzcUXNAx8IX9H3vq5OY3q/Ggygg8SKFH5vdXOD2viyVa2EEiQHs3X5OM02XJSbi9iP6A1N3KWhj8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789242934; c=relaxed/simple; bh=juFXH2sCCFwjZSk73fHl7B/7iZX6xIYJXcPclZcecEo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VqmPht4wQSDZSq3SLFCzwgv8qY1sd7d6L84n+mocuKEM+lUCfixA13WMzl6BVCBdwEw3Z4s5+UDWQbUzWwHFvh42p2Lva4L0ShaPaWSBCNZom/71wrq3yeSabGiDZKqDqfmKSjjJ2RCvGS2Z8AVcKOmmdoMXm27HRXaRJGcuR00= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LLwo46NX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LLwo46NX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BBF6B1F000FF; Sat, 12 Sep 2026 19:55:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789242933; bh=mipwrCBFQ7T1FB8kMlY0y+1HAJrFWixTGYkUR9U2WyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LLwo46NX32zvpvWgBtBdgDqKlm9X+Q4Mw2tI/QW8Lyxp2kSIQgT2GoQo3k6r/L3ze oFBB4p/bmum0lvXiz1N//8ri5CZlyFe6udqVifaOffWMQ+vJJ15biGp1JEkpuTwqhe 3zqdFPBDD3ApWdmFjTrlxlssVKWVBKqlXGN1wefM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Karl Mehltretter , Sasha Levin Subject: [PATCH 5.10 578/798] serial: amba-pl011: unprepare console clock on unregister Date: Sat, 12 Sep 2026 09:03:26 +0200 Message-ID: <20260912065530.378296880@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Karl Mehltretter [ Upstream commit 7f93da9d78d433c37836d85de475c5d884ad58ed ] pl011_console_setup() calls clk_prepare() on the UART clock, but the console provides no matching teardown, so the clock is never unprepared when the console is unregistered -- via the sysfs "console" attribute or a driver unbind. Each re-registration prepares the clock again, leaking one prepare reference per cycle. Even where preparing the clock has no hardware effect, the stale reference leaves the clock framework's prepare count unbalanced. For providers with prepare/unprepare operations or runtime-PM integration, it may also retain resources after the console is unregistered. Add a console .exit() callback that clk_unprepare()s the clock, balancing the clk_prepare() in pl011_console_setup(). Fixes: 4b4851c65d92 ("clk: amba-pl011: convert to clk_prepare()/clk_unprepare()") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter Link: https://patch.msgid.link/20260724213348.77418-2-kmehltretter@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/tty/serial/amba-pl011.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 500f46bb06c85..5b2c31a3e9920 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2334,6 +2334,15 @@ static int pl011_console_setup(struct console *co, char *options) return uart_set_options(&uap->port, co, baud, parity, bits, flow); } +static int pl011_console_exit(struct console *co) +{ + struct uart_amba_port *uap = amba_ports[co->index]; + + clk_unprepare(uap->clk); + + return 0; +} + /** * pl011_console_match - non-standard console matching * @co: registering console @@ -2400,6 +2409,7 @@ static struct console amba_console = { .write = pl011_console_write, .device = uart_console_device, .setup = pl011_console_setup, + .exit = pl011_console_exit, .match = pl011_console_match, .flags = CON_PRINTBUFFER | CON_ANYTIME, .index = -1, -- 2.53.0