From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB91D37FF76; Sat, 12 Sep 2026 18:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237250; cv=none; b=QJAsziTM/Jaq//UojgnCJbyjwkzbRoq1zJRnPy8P+9TMt79yUOuSPcRgkQGXNSCu47NFpaVD8eJYMjE/XiVWD77LGjsi8OYmRfMmzIYHuZfCBjFWKhYPdnYASFGV99I5GhI3yRQaFfBsr5MX6Ive4oOWJmDU3GLEIkvqILlNKGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237250; c=relaxed/simple; bh=D8HKqDrV2fHgGoLA3iuyoHNnhZtrgmfBHBtMlI6j47w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fAW7aqIw+VZl7golnBpMklqED5xEYNrs0VFaRbz87f5W1qBmiXmxIIu8Lf0F8/2w7qsMLx0Pt1G8HKTjFM0kCZ1CAIXtYyXJvhVYqj34T2usnYWANACz6bbmalEeRBvRZsqUgYkpx1vVG2HP7VlPz05bd1RQUIArYkv3uPUuTJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=r6XSfx6W; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="r6XSfx6W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 78A351F000FF; Sat, 12 Sep 2026 18:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789237248; bh=ySaERNr4cE3RddVYFpUNuuitoRVScasna6eBMkS1A8o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=r6XSfx6W0DSSWCTmQykD0fO1sfEXQlOHqKdzc0m7LpOSwPrksbB4ZHFl5C1J3+oQJ LlcKQt6g/PlfQpxP4FQ0kjSdXstMhAF6esKmnlobndkjBvKx31C1fymIZKTH7uxSO9 IX2B6w5TgeeVs/ynVQD28KyKMs1tsGwqXqjoRQ/Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 5.15 167/935] platform/x86: dell-wmi-sysman: Dont hex dump attribute security buffer Date: Sat, 12 Sep 2026 08:53:17 +0200 Message-ID: <20260912065530.647788494@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An commit 83c80495e45eddf64c6525fb582d8db68f256b71 upstream. set_attribute() populates the security area of the BIOS attribute request buffer with the current admin password via populate_security_buffer(), then dumps the whole request buffer with print_hex_dump_bytes(). This can expose the plaintext admin password in the kernel log. The same issue was fixed for the password attribute path by commit d1a196e0a6dc ("platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data"). Remove the remaining dump from the BIOS attribute path. Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5 Signed-off-by: HyeongJun An Link: https://patch.msgid.link/20260614045353.143500-1-sammiee5311@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/dell/dell-wmi-sysman/biosattr-interface.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/platform/x86/dell/dell-wmi-sysman/biosattr-interface.c +++ b/drivers/platform/x86/dell/dell-wmi-sysman/biosattr-interface.c @@ -84,7 +84,6 @@ int set_attribute(const char *a_name, co if (ret < 0) goto out; - print_hex_dump_bytes("set attribute data: ", DUMP_PREFIX_NONE, buffer, buffer_size); ret = call_biosattributes_interface(wmi_priv.bios_attr_wdev, buffer, buffer_size, SETATTRIBUTE_METHOD_ID);