From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12B9B390205; Sat, 12 Sep 2026 19:57:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243059; cv=none; b=t+EbbtGCFHoFZkx9gyy1PCfqs026jCz1Ahow2fgCAmu9cGmf8rjSJdXtS7Yn2BKottE83oShyGr9VSD79l2MWgN0dllp3g3SsRc0hDKom5fk2DAUQDqlAfZU7bT95ToppZ1ZlekzL/y/eT9jpD376rp5Et7A21n+1MnvPTcHx54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243059; c=relaxed/simple; bh=g8LAqSwzhsPUjBZQdiHL+u5JCezlZgJJUa3dng2W7UY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HDul3bpoNRKj62lDOzBPgAmO1psXrgSXgpy9bIuMYbVJudwrjo10gWi28EFaR74qvCdYpBKXU+sC0taBXeQC45ZZi1y1FxT2e5cbaMAstk7sBNSCQxepoayYtSIw/7QSbqmVPPrOnDRK15gX95Qk/iqy8ZSZbq87Ah4eCMmPDnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z5ScbB9Q; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z5ScbB9Q" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 682931F000FF; Sat, 12 Sep 2026 19:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243058; bh=v12SZSljFN2vARUXJQlkZ8ISDGGbiwNMrc25m9L6fiE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z5ScbB9QQOv95b9NDKEbUfVnIBds1RKNK1LahlX1Q9h7nenqTF34UmZcht+tp4R3+ UDaTv+tS5F2t0dXGFC4tyu3GTTNrguD2p6x1BEABWVerq7yn7RgNkUftu3geczoKI4 dUH6uJRESSf10GyGFLalR66k/f0/5pOotZyn+7mk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jernej Skrabec , Chen-Yu Tsai , Sasha Levin Subject: [PATCH 5.10 622/798] drm/sun4i: crtc: Propagate layer initialization error Date: Sat, 12 Sep 2026 09:04:10 +0200 Message-ID: <20260912065531.378419539@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jernej Skrabec [ Upstream commit 7061ff05ed4a3cf16e83f7e3ad09cbd212508a32 ] sun4i_crtc_init() returns plain NULL when layer initialization fails, while all its other error paths return an error pointer. The only caller, sun4i_tcon_bind(), checks the result with IS_ERR() and happily continues with tcon->crtc set to NULL. sun4i_rgb_init() and sun4i_lvds_init() then dereference it in drm_crtc_mask(), which oopses. Return the error pointer instead. Fixes: dcd215801b02 ("drm/sun4i: Drop primary layer pointer from sun4i_drv") Signed-off-by: Jernej Skrabec Acked-by: Chen-Yu Tsai Link: https://patch.msgid.link/b26a0d427d9dfae9c82e3ca90a67d24d8ece5a28.1785772659.git.jernej.skrabec@gmail.com Signed-off-by: Chen-Yu Tsai Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun4i_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_crtc.c b/drivers/gpu/drm/sun4i/sun4i_crtc.c index 3a153648b3698..b11988bbbaa20 100644 --- a/drivers/gpu/drm/sun4i/sun4i_crtc.c +++ b/drivers/gpu/drm/sun4i/sun4i_crtc.c @@ -202,7 +202,7 @@ struct sun4i_crtc *sun4i_crtc_init(struct drm_device *drm, planes = sunxi_engine_layers_init(drm, engine); if (IS_ERR(planes)) { dev_err(drm->dev, "Couldn't create the planes\n"); - return NULL; + return ERR_CAST(planes); } /* find primary and cursor planes for drm_crtc_init_with_planes */ -- 2.53.0