From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D5FF392806; Sat, 12 Sep 2026 19:59:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243184; cv=none; b=to7LN41A7iJQHgiERMlYfHFXQyILVTYGTX1klmYMZG2AftsC5AT2A/HY1melBuuKpfCONZHOs2r7it6jhAYAqtmFPWPK9rXPWCatxp5tVR9lZr0+cqVZnJJzE1KiGXp9HDto8BovXmlNHL/oMVV0ufPbrf5UXXiMkFgMer5uMpk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243184; c=relaxed/simple; bh=wzZmdZe3ExeSNMS0JAsSyu4mpbBWY3bkAAfUHjNIxY0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tQEBMJy8G7QPSHi9TXU+lTLbQU3RX/wC6Ffr2hskIsvX/Y4GgSgsMeX5SdtHq+ysVq0LDeoCEKdy8msf92BDwA/lajWUbAeHnvaIHxYZwY2+5RqeTM9kxisT5Xr4mjhX+3kr/RMxL/MUpDMofTreBZfvrM0dAZdJswecs1NTVZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Hlu7GM87; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Hlu7GM87" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E5101F000FF; Sat, 12 Sep 2026 19:59:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243183; bh=XAWhTX9KKfmZwOBoE5853JW6OnWlzbsP+HDQiPaRces=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Hlu7GM87m2w9/VWSjmTTDSDJplHz3gJ1tTeRLzCi5OHNS6qRiKknGxBkX/dWIW/s+ BQhN+Y9qSeHT/P8s+/i+NFma5tfLEO6WyBqvVKC2+KNtCyZ8BUJsHlomWKZvVJi8C8 pogyrNsQOU0K3JzyDv5eDs4U2Ddieazi5Q27hxoM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Baolin Wang , Babanpreet Singh , Mark Brown , Sasha Levin Subject: [PATCH 5.10 667/798] spi: sprd-adi: Fix probe succeeding without registering the controller Date: Sat, 12 Sep 2026 09:04:55 +0200 Message-ID: <20260912065532.394025632@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Babanpreet Singh [ Upstream commit f092e1c935015ee0a0fea1a0374f4cab7b71953c ] With CONFIG_HWSPINLOCK=n the of_hwspin_lock_get_id() stub returns 0 unconditionally. In sprd_adi_probe() the guard if (ret > 0 || (IS_ENABLED(CONFIG_HWSPINLOCK) && ret == 0)) is false for that 0, so it takes the else branch, where the switch has no case for 0 and lands in default: return dev_err_probe(&pdev->dev, ret, "failed to find hwlock id\n"); dev_err_probe() returns its err argument unchanged, so probe logs "failed to find hwlock id" and then returns 0, reporting success. sprd_adi_hw_init(), the restart handler and devm_spi_register_controller() are all skipped: the device binds but no SPI controller is ever registered. The hardware spinlock is optional for this controller and the -ENOENT arm already covers "no hardware spinlock supplied". Treat the stub's 0 the same way and continue without a lock; all four users of sadi->hwlock already test it for NULL. This is not reachable on production kernels. Kconfig has depends on HWSPINLOCK || (COMPILE_TEST && !HWSPINLOCK) so the affected configuration exists only under COMPILE_TEST, where no real hardware is present. Found by smatch: drivers/spi/spi-sprd-adi.c:560 sprd_adi_probe() warn: passing zero to 'dev_err_probe' Fixes: f9adf61e983f ("spi: sprd: adi: Change hwlock to be optional") Assisted-by: Claude:claude-opus-5 Reviewed-by: Baolin Wang Signed-off-by: Babanpreet Singh Link: https://patch.msgid.link/20260729053543.7-1-bbnpreetsingh@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-sprd-adi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c index 307c079b938dc..f01610824a209 100644 --- a/drivers/spi/spi-sprd-adi.c +++ b/drivers/spi/spi-sprd-adi.c @@ -500,6 +500,12 @@ static int sprd_adi_probe(struct platform_device *pdev) } } else { switch (ret) { + case 0: + /* + * Only reachable with CONFIG_HWSPINLOCK=n, where the + * of_hwspin_lock_get_id() stub returns 0. + */ + fallthrough; case -ENOENT: dev_info(&pdev->dev, "no hardware spinlock supplied\n"); break; -- 2.53.0