From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D8FF399351; Sat, 12 Sep 2026 20:01:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243301; cv=none; b=BUw7ahDI+P2ZY5wJZBltk56p5oeeShuRXZNu2xjLFa6nW9prycq5B0iros6ljf15YsauwZjoYSB/Hnu+yuGr6VckHeYWOI2jdAmAdAaKhwpodZ3WewoHf5J8g+nbTLvdyPsXSGjLUWlv3ZgZAnZtuNUEofupQPTyYOp+uINBu10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243301; c=relaxed/simple; bh=MbmJWQbJIT+AHcXDmrBcMZeQVpnt4BpAzOe8XEOQWZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LivCjTH4Dm0A/nQooqzeYjoOEZCckboHJ9OCztn6cn1a0bvrYQQYy5lDruGh0E9KOG8wL07wz1B8eTmO7B9SnCkow4dZ48gH3NScbakXjJOdu596pSDJWa8gEu+0YEVBTpYfc2wU0sZH+mBQRShOMXuTMspv7KPZHF0YNdwGUMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uXNRrHt4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uXNRrHt4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8DCF1F000FF; Sat, 12 Sep 2026 20:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243299; bh=BWthRpc9DNn0QvCtW/OkFounxT+mVmlE3cIaRjdcYyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uXNRrHt4gBJ3drArWZ2bhvYGfxbrv7hLy2KNs+4KKYwc0n2Ka2AvoFWc1HXpbrVGW VXbzuQfq7rFa/WQA/QcIXoBE9GhjHmUUKJ7Yakq22PKSMxHbNWSkMY4lD/9lI7Wrht ZL7JCMBaJjcrXAQ9z/WAD2CzMbsS5qJhu4fw8Vjw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laurence Oberman , Chandrakanth Patil , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.10 708/798] scsi: mpt3sas: Avoid freeing unallocated PCIe SGL buffers Date: Sat, 12 Sep 2026 09:05:36 +0200 Message-ID: <20260912065533.314013535@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chandrakanth Patil [ Upstream commit b9f679dfe629004b593f018df33b330d799bcee4 ] _base_release_memory_pools() unconditionally frees every ioc->pcie_sg_lookup[] entry, including ones the setup loop never allocated after a partial failure, causing a "bad dma" warning on debug kernels or a NULL pointer dereference otherwise. Fixes: dbec4c9040ed ("scsi: mpt3sas: lockless command submission") Reported-by: Laurence Oberman Signed-off-by: Chandrakanth Patil Link: https://patch.msgid.link/20260808151010.185603-1-chandrakanth.patil@broadcom.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 78b178aa46e94..6a72f51f083a7 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4924,6 +4924,8 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) if (ioc->pcie_sgl_dma_pool) { for (i = 0; i < ioc->scsiio_depth; i++) { + if (!ioc->pcie_sg_lookup[i].pcie_sgl) + continue; dma_pool_free(ioc->pcie_sgl_dma_pool, ioc->pcie_sg_lookup[i].pcie_sgl, ioc->pcie_sg_lookup[i].pcie_sgl_dma); -- 2.53.0