From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A818C3A6EF7; Sat, 12 Sep 2026 20:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243381; cv=none; b=IRzapKws/VymvXC7yNQHU29tIUzKuN/9uF3X9Pa+5gxVKij1f4R/DtfZzcRIYuOQXCOhQruVkEz97SebooGU0R0WunBqPrrfkjukcCZvC4HbCKsiGPJqWdITxywWLC49wwgDwbUdDQOQe0N9YPo3kK+6rugaodSitOvGTD+7qBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243381; c=relaxed/simple; bh=36lFWTPaomfQElszEFMwo6M3RGNdR31oAQ04856jtLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V425xWzGVzdgfV7C8GgOdeofI34VEZVOe/DHCOt/04OjPVgETSCXEAx//B0X74OXowVS7VEhUDvV4wIDuA2OrFC95g5mi8rDj5bpLYbb4NgJ1dXCqtaw2QpPCR1qLZxhjaZI525jDRxqMz7ACBo53CTbRYWhGMAid6JsldQf/lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=IvBLxfTL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IvBLxfTL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6F291F000FF; Sat, 12 Sep 2026 20:02:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243376; bh=dL6Km1uF7RfGUVIpcekxGImcIqFO0A5GOUxrD4vKIsk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IvBLxfTLltVXx/NaI8nR49VqewF/T8dVgYuq++z05DYcccaKGVCPUwfIo17vEbQOs g0vt2n9JJ1HQQICrsYR8dTFdfHVf1JqV/MbOBSaJ+WwWJARcCZ/ftwLOo/4boRJwy3 ducedRpIvoXNdjBsbYF9Mgd9Wp862zL0en3ApYqo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Wupeng Ma , Stefano Garzarella , Nguyen Dinh Phi , Paolo Abeni , Sasha Levin Subject: [PATCH 5.10 733/798] vsock: use sock_error() to consume sk_err after a failed connect Date: Sat, 12 Sep 2026 09:06:01 +0200 Message-ID: <20260912065533.877416456@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nguyen Dinh Phi [ Upstream commit 96cbf89993091a163bfedec52a3bd683dc94b3b4 ] vsock_connect() returns sk_err to userspace but does not clear it: if (sk->sk_err) { err = -sk->sk_err; For a blocking connect() the error has already been delivered as connect()'s return value, so leaving it set causes subsequent operations like poll()/epoll() to keep reporting POLLERR even though the connect failure was already delivered. The error should be consumed once it has been returned to userspace. Switch to sock_error(), which reads and clears sk_err atomically, matching the behavior of other protocol implementations such as __inet_stream_connect(). Fixes: d021c344051a ("VSOCK: Introduce VM Sockets") Tested-by: Wupeng Ma Reviewed-by: Stefano Garzarella Signed-off-by: Nguyen Dinh Phi Link: https://patch.msgid.link/20260813173024.2362935-4-phind.uet@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- net/vmw_vsock/af_vsock.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c index 27f2fbf56616c..15dd900beaf22 100644 --- a/net/vmw_vsock/af_vsock.c +++ b/net/vmw_vsock/af_vsock.c @@ -1504,12 +1504,10 @@ static int vsock_stream_connect(struct socket *sock, struct sockaddr *addr, prepare_to_wait(sk_sleep(sk), &wait, TASK_INTERRUPTIBLE); } - if (sk->sk_err) { - err = -sk->sk_err; + err = sock_error(sk); + if (err) { sk->sk_state = TCP_CLOSE; sock->state = SS_UNCONNECTED; - } else { - err = 0; } out_wait: -- 2.53.0