From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14EF9274B46; Sat, 12 Sep 2026 18:28:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237708; cv=none; b=ZeIHbELYCSC0CGr7IBcxzHETRgbnb37KOFrFPSYtGGS424BlIlGoPuzRmspG06zZ9PvAYG5Z/qGKlNeMpwZPlx8dmn6Wx3VOa3M0Wc/+mtSXEJu5Zz9DIi6eIFBCzXPznKOjYbaItMNMSFOT4Dv4SmSWxEuI8ZbvWzRa3WwW4aE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237708; c=relaxed/simple; bh=t9I/gJrtgx34GwVYo5DnrJw0wpfwseGmCPi1xv1Kf9k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AZmKQOpgTqfB8zbaza2rJS4rMhNIfz9NixkzoDkrLghA9rSbTdA29DkgJ+5weFgiT29QSugxXHzN7UmZSiU5sutDd6zq7WUU7IYpaPH/ri4XdritiyHneAkswo3/djjHPXQ2GqPqV3NCzNM/1Fls0l51mJCzzaPA7FzrNIIdHZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RPd1bswi; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RPd1bswi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3EFD1F000FF; Sat, 12 Sep 2026 18:28:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789237706; bh=Ijs9luCPHczOwsl08UMZT+WFxgq4FltGCCbPiiiarZE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RPd1bswi4rDVTWmQiHM5Ol//2BMQ5hGswwfEtv5BqAgTr+vq+28kpGvYRk/AjfsgR O4XIse75B5n+onpbllCi57kOE3a7FMzYUXdql7JtYMiig55W1AS/9cB9UvjEo02X9F G8XHe+Az816diXcT4o/jSdefQIwZrGyt8sU3kVWg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Fan Wu , Hans Verkuil Subject: [PATCH 5.15 314/935] media: cx23885: cancel NetUP CI work before teardown Date: Sat, 12 Sep 2026 08:55:44 +0200 Message-ID: <20260912065534.007560974@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit 4e143d662ca94888b494b2427fc9e34494eb933a upstream. netup_ci_exit() frees a netup_ci_state while its work item, netup_read_ci_status(), may still be pending or running on the system workqueue. The worker obtains the state with container_of() and dereferences it, so it must not outlive the state. netup_ci_init() queues the initial status read, and CI GPIO interrupts subsequently queue the same work from netup_ci_slot_status(). During remove, cx23885_finidev() calls free_irq() before the CI device is unregistered. free_irq() prevents further IRQ handlers from running, but does not drain work queued previously, so the worker can run after netup_ci_exit() frees the state. Call cancel_work_sync() before dvb_ca_en50221_release() and kfree(). This issue was found by an in-house static analysis tool. Fixes: c184dcd28233 ("V4L/DVB (10798): Add CIMax(R) SP2 Common Interface code for NetUP Dual DVB-S2 CI card") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/pci/cx23885/cimax2.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/media/pci/cx23885/cimax2.c +++ b/drivers/media/pci/cx23885/cimax2.c @@ -528,6 +528,7 @@ void netup_ci_exit(struct cx23885_tsport if (NULL == state->ca.data) return; + cancel_work_sync(&state->work); dvb_ca_en50221_release(&state->ca); kfree(state); }