From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C03E83ABD96; Sat, 12 Sep 2026 20:04:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243487; cv=none; b=aRUGLqWq91ATTKYI4iX+H23hCemml+mJAiJYrHmyUb0wd+Xuj80J3mxqZfCwCLDklnQt3fE719V99Npr7I3Qq1mwH+8dxV1LECin9g2k3XMTie5V6zCzpGw3cH0HmeH2QAgKMzN7HWHcxGClzkqJmswPA2KKQkcIuHdM44qATCk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789243487; c=relaxed/simple; bh=+tVI98R5QDKbQFVW2Gy7yJIaRyAJf16jEz4JOh2CICQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ag/cWppkDSK7oS6U9z5s/4xuI6bl8Cd6FirxizaDuqm37NrOox4HTAtQl3A80aFBMWF/jjNoAMaurzHYZUPubJe1TBkKUv7eD7XjCCRAtQzcCp29nLlYmhI1MLaO1+Jmlg+QRj4ObX4hCuW65znzNAwjRro8JkNY9MHhSt3+d3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wwq0XFeV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wwq0XFeV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BFCD1F0089B; Sat, 12 Sep 2026 20:04:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789243481; bh=c0Dbkt5cOs2mqRZDjhEz/oXXbYYlM9fBUzMvCesInC8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wwq0XFeVwXmD/u+V/62v38HWd83C3Qw7NioKroJNFgqDOzmD0N/XQ9bNwN9JQaQN7 +jON7IyhEOtc0rsb3LC5dJf/uQ5BJlNbvQzp9U/OcPYNwe7apIHnZBTsZ3K4t4cikl bDsF7tyARznFAEWhExqsenOb8+f6P/S9MFitT+Z8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hidayath Khan , Mahanta Jambigi , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.10 743/798] net/smc: free pending qentry in smc_llc_flow_stop() before memset Date: Sat, 12 Sep 2026 09:06:11 +0200 Message-ID: <20260912065534.103441046@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mahanta Jambigi [ Upstream commit 5ee0ceddc7785c6dcf4a8107fef01f0414a354f4 ] smc_llc_flow_stop() resets a flow struct with a blind memset: spin_lock_bh(&lgr->llc_flow_lock); memset(flow, 0, sizeof(*flow)); flow->type = SMC_LLC_FLOW_NONE; spin_unlock_bh(&lgr->llc_flow_lock); If flow->qentry is non-NULL at this point the pointer is overwritten without the allocation being freed, leaking one kmalloc object. A late-arriving duplicate CONFIRM_LINK or ADD_LINK_CONT message can set flow->qentry after the legitimate message has been consumed by the waiter via smc_llc_flow_qentry_clr() (which NULLs the pointer but leaves flow->type non-zero) but before the flow completes and smc_llc_flow_stop() runs. In that window the duplicate is stashed into flow->qentry, and then lost when smc_llc_flow_stop() zeros the struct. Call smc_llc_flow_qentry_del() inside the lock before the memset. smc_llc_flow_qentry_del() already checks flow->qentry before freeing, so the normal case where no entry is pending is a no-op. Fixes: 555da9af827d ("net/smc: add event-based llc_flow framework") Reviewed-by: Hidayath Khan Signed-off-by: Mahanta Jambigi Link: https://patch.msgid.link/20260818073943.1108383-1-mjambigi@linux.ibm.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/smc/smc_llc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/smc/smc_llc.c b/net/smc/smc_llc.c index 572d02bfd3eda..e4d2abec8ec86 100644 --- a/net/smc/smc_llc.c +++ b/net/smc/smc_llc.c @@ -276,6 +276,7 @@ int smc_llc_flow_initiate(struct smc_link_group *lgr, void smc_llc_flow_stop(struct smc_link_group *lgr, struct smc_llc_flow *flow) { spin_lock_bh(&lgr->llc_flow_lock); + smc_llc_flow_qentry_del(flow); memset(flow, 0, sizeof(*flow)); flow->type = SMC_LLC_FLOW_NONE; spin_unlock_bh(&lgr->llc_flow_lock); -- 2.53.0