From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DA5F355055; Sat, 12 Sep 2026 18:30:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237822; cv=none; b=HnWy832/S4D/bMyL/ftIj2pgDt2mTRCjaDuRdxJU5mYGMsXX7peBx5YhjFYgtQHgYU4uIN6J9LPfMkwyEBlS7gv9OjUBmmNXvUClRSKp3CqDDzWGq1PwquyhijoOLHtX9p4gMLv0coTsfXpQEKu7T0Tc2RVJaX5XO+X9QrQGz6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237822; c=relaxed/simple; bh=IE65A81erHV7wygwQDctLoa0PU9KVCtJD70vjJGCAkY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=np8yPSIw8gOiJfWNNBJaEvjYI0CLyNUHJ/vgc1uwQgKwPGrvFlVzgCKb3i+G2FlDGhRcx1ql74N0LopUsO7xL7bBt7+whbhCMktINUNsNQwP97JMOHC9/CgrR3paAFq8vwdhmG4rNeWgS5ENkR2Ru8jsdLYx7JJoOwOVJbN+wTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=vhbLH9pp; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="vhbLH9pp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18B571F000FF; Sat, 12 Sep 2026 18:30:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789237820; bh=ZI6y9QeJNPQRsM5igYWg1fS1LVIDA3QMDvDWXmzLrI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=vhbLH9pppZjLgW9gXMakMzO0g6Xomqxeuqxtk61Vnl5mgeRNexzvE7I1eP4ZwZ0Qj mI/EnpvLGV34IXKq772dsoYj4WOg6w15NcV+UV+MTC/u2UEUucUTpargE4yz+apQej u/nPVESCmDYKQKKAvkmTkJf9mfMZ2zx5T61Q0ARk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nilesh Javali , Hannes Reinecke , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.15 335/935] scsi: qla2xxx: edif: Fix NULL pointer deref in RX SA delete check Date: Sat, 12 Sep 2026 08:56:05 +0200 Message-ID: <20260912065534.489698343@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit c20ee380ca59c5a8646750c4849969a815924e2e upstream. qla_chk_edif_rx_sa_delete_pending() obtains the SCSI command via GET_CMD_SP(sp) and immediately dereferences cmd->sc_data_direction. That command pointer can be NULL: the firmware may post a status completion for a command that has already been returned or aborted. The caller qla2x00_status_entry() acknowledges this on the very same status path, re-fetching GET_CMD_SP(sp) and bailing out with the "Command already returned" message when it is NULL -- but that check runs only after qla_chk_edif_rx_sa_delete_pending() has already dereferenced the pointer, so a NULL cmd crashes the kernel in interrupt context. Return early when cmd is NULL, before touching cmd->sc_data_direction. Fixes: dd30706e73b7 ("scsi: qla2xxx: edif: Add key update") Cc: stable@vger.kernel.org Signed-off-by: Nilesh Javali Reviewed-by: Hannes Reinecke Link: https://patch.msgid.link/20260723050413.3897522-47-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_edif.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -3372,6 +3372,9 @@ void qla_chk_edif_rx_sa_delete_pending(s struct scsi_cmnd *cmd = GET_CMD_SP(sp); uint32_t handle; + if (!cmd) + return; + handle = (uint32_t)LSW(sts24->handle); /* find out if this status iosb is for a scsi read */