From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93333355055; Sat, 12 Sep 2026 18:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237842; cv=none; b=msgWv2XpJIyf7hto6frc+GpbGFmzFsTOJZ3Jux0gCmbKx3BzYrEn0VC9g/FDUyZiTT3vp1xbfOwo2CguytgyQ5VJTtgw3G/3s6ukNuGVq2jSGj2KZEh9QQB1GJ35ULJMcNtJVpRy/nwkwVDLirOmHlujlOIF5PX3ncoNNqH0frg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237842; c=relaxed/simple; bh=WKmJys62QCKt4ISCz49QCKym6Jv3+UmZmVYwV2i7xqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bmljce/F28qPuZLx9qzQQIfPV1AefttVOVbCIdRWcY+FWonlqR6R+wpUqWNBMTKqmdaCxQFFvheX+2OqeE+vl2iG0Pz76JgfSdWn5Hmeka7a/naQwN299ZMIFgXHhADtfSh2Mac3yAWAz95djsDcrgxwE9rYKCBfukHDBcBb/kc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=R4DKE7uK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="R4DKE7uK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12DED1F000FF; Sat, 12 Sep 2026 18:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789237840; bh=zWgj0nAfdO+4qUNpx050unyCnHPym9kyxbKItrT8jZ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=R4DKE7uKjHC4Enp8GefIRM2RX6oqMafQxSGOs575Y9GPFA8NedVRBOg8JUkg/sK3F sLylTJ/qT+9RzW1/tir9vDz6lJI2iOLkVdLJZGn9hqbbJqyZUKD+xrCnD8rInswcW1 wzwCXD0wGPlCqEjyy5+CiNnMQEWxUshiRJRW0lWM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Nilesh Javali , Hannes Reinecke , "Martin K. Petersen (Oracle)" Subject: [PATCH 5.15 339/935] scsi: qla2xxx: Bound image count in qla2x00_update_fru_versions() Date: Sat, 12 Sep 2026 08:56:09 +0200 Message-ID: <20260912065534.581637682@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nilesh Javali commit de62cf265dbe309f34f144a6cdbca9240317727e upstream. qla2x00_update_fru_versions() copies the user-supplied BSG request into a fixed 256-byte stack buffer (bsg[DMA_POOL_SIZE]) and then iterates list->count times over the qla_image_version array embedded in that buffer, advancing the image pointer each iteration. count is taken directly from user input with no upper bound, while only (DMA_POOL_SIZE - sizeof(list->count)) / sizeof(struct qla_image_version) = 6 entries actually fit. A larger count walks the image pointer off the end of the stack buffer, reading adjacent kernel stack memory and sending it to the device via qla2x00_write_sfp(). Reject requests whose declared count does not fit in the buffer. Fixes: 697a4bc69159 ("[SCSI] qla2xxx: Provide method for updating I2C attached VPD.") Cc: stable@vger.kernel.org Signed-off-by: Nilesh Javali Reviewed-by: Hannes Reinecke Link: https://patch.msgid.link/20260723050413.3897522-56-njavali@marvell.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Greg Kroah-Hartman --- drivers/scsi/qla2xxx/qla_bsg.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/scsi/qla2xxx/qla_bsg.c +++ b/drivers/scsi/qla2xxx/qla_bsg.c @@ -1578,6 +1578,13 @@ qla2x00_update_fru_versions(struct bsg_j image = list->version; count = list->count; + + if (struct_size(list, version, count) > sizeof(bsg)) { + bsg_reply->reply_data.vendor_reply.vendor_rsp[0] = + EXT_STATUS_INVALID_PARAM; + goto dealloc; + } + while (count--) { memcpy(sfp, &image->field_info, sizeof(image->field_info)); rval = qla2x00_write_sfp(vha, sfp_dma, sfp,