From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4326535DA40; Sat, 12 Sep 2026 18:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237998; cv=none; b=mLUFqBzYMjm1YWOVjQyOzazbLqUPMBge2/293oQiigqpQWQpRj7V0IxDdpEWPi/ZXipD0ngIveiflnyBaSGCqutQ1TgB6ygqRmLOGFOrWhZ4BWlzAd2N2P38vhlmmPWXls4EWTNK9qSSBIYvpevd/PC4l5egvDZmEiarDCDuL7A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789237998; c=relaxed/simple; bh=hboOISNZ37TS4aqiKJz8F352W8uAnCQjD1/N6GdN1sI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MlMYGS6MguZF4nKZ/s0c1RExbyW4PjTA5xNvUCVyNaFA4E/vtEi3wexgPsGNoBpzyHnKBQqf/+rifbRF0KWpJqwOho9OGpPW4gckY7qmbRLJDo8Ad5RkDIy7g/YTO3lBI4w5BBjA98pUb3swMi7eIyyUJlSybfA2Crd/5RKspqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kSsAYKv4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kSsAYKv4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EDB01F000FF; Sat, 12 Sep 2026 18:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789237997; bh=hb7UNxJcPlS6gUA0KDbBfz56ekv3sStb3pxhZfbe14Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kSsAYKv4kwUz8+au6kvXhLeklyWlrdX+rieLNWKAXQcHanUUqGi15D76+bFagBMrK dLN6HsrYjGEh6SMo3XyFCyoUcQRjphc8fyGvLaHx9mioEAzu703UuHPH5pSGBYDNiE 78rvT3+HfiiD8CmueSvlEPY3BY4JsGvCbbpGUwJA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, SJ Park , Brendan Higgins , Andrew Morton , Sasha Levin Subject: [PATCH 5.15 372/935] mm/damon/core-kunit: check region count before testing in split_at() Date: Sat, 12 Sep 2026 08:56:42 +0200 Message-ID: <20260912065535.344331759@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: SJ Park [ Upstream commit 9b18ef3c3aa1ce24176e340061caf15fa2742564 ] damon_test_split_at() test next region that is assumed to be created by damon_split_region_at() invocation. But the split might fail. In this case, the succeeding test may dereference invalid pointers returned by damon_next_region(). The invalid pointer may not cause a really bad user impact, because of the implementation detail. It would only read wrong contents in the belonging damon_target struct. Depending on the future change of the offset from the link header to the accessing field, this could also be really dangerous, though. Still, the realistic user impact would be limited. It would affect only test run setups. Fix it by testing if the number of regions was also changed as expected and exit early for the failure. The issue was discovered [1] by Sashiko. Link: https://lore.kernel.org/20260718001442.87129-3-sj@kernel.org Link: https://lore.kernel.org/20260714142352.100478-1-sj@kernel.org [1] Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests") Signed-off-by: SJ Park Cc: Brendan Higgins Cc: # 5.15.x Signed-off-by: Andrew Morton Signed-off-by: SJ Park Signed-off-by: Sasha Levin --- mm/damon/core-test.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mm/damon/core-test.h b/mm/damon/core-test.h index c19da2e3d4936..b0d11a208fcd3 100644 --- a/mm/damon/core-test.h +++ b/mm/damon/core-test.h @@ -160,6 +160,10 @@ static void damon_test_split_at(struct kunit *test) } damon_add_region(r, t); damon_split_region_at(c, t, r, 25); + KUNIT_EXPECT_EQ(test, damon_nr_regions(t), 2); + if (damon_nr_regions(t) != 2) + goto out; + KUNIT_EXPECT_EQ(test, r->ar.start, 0ul); KUNIT_EXPECT_EQ(test, r->ar.end, 25ul); @@ -167,6 +171,7 @@ static void damon_test_split_at(struct kunit *test) KUNIT_EXPECT_EQ(test, r->ar.start, 25ul); KUNIT_EXPECT_EQ(test, r->ar.end, 100ul); +out: damon_free_target(t); damon_destroy_ctx(c); } -- 2.53.0