From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AA30399369; Sat, 12 Sep 2026 18:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789238293; cv=none; b=rlWeZeh6GAsdjLiBOBqTgFnlEjGfiIMJk24URQYO9Uj/6ue1HmAp15V7IulZqCaOYGI5K+I80//cvEU4VHwRWWt2Ilr76fY5PwZTqlkkpg6XDWYT5DL8QFxvVxYRa39Cos0zg8jUgMbd5dGVvtXjs10ClkD9QwTZalO+fcPn4ns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789238293; c=relaxed/simple; bh=IKcmvnmtCYRbgbEyXbYR1j3hLBu2c27V1HMd/RN/IVI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CGiBIPs4nF+W1QOtLszgmETPjuMFSAa8+tOVRrcmCLQVe9kDfRWCMbsDPTdr1NHEQAaOJ2x8175j1cPdVo404jHZ529f7QzuJMplxy5D28FRNNoXpgkZs1MhRJhzt+Q/rYUEX0LZb49+NFiD6uPqltAojf32I2xdIDnuU5fbmvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TPR8wI1Z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TPR8wI1Z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5D161F000FF; Sat, 12 Sep 2026 18:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789238291; bh=WOBqe8FcVFUzrmn80YkpnNz8KTXVbc9QAieYuEFSw18=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TPR8wI1ZnvM78PYdKAvVFjJqBVlftM/NJrZJZxN9QF4l0W5CtM5JWqTUTTQLgFx6z +WC8FNdCJts9Zyev/x5gAeiG803sd6S641/+JHw4MZ+jCkfsWh/nvZf9wZoRSzA65P sUBKn/Gtr5jrQzpIAnxJhDD8Fp079DyCpZRgg4IA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, sashiko-bot , Srinivas Kandagatla , Vinod Koul , Sasha Levin Subject: [PATCH 5.15 431/935] soundwire: qcom: Fix port exhaustion check in stream_alloc_ports Date: Sat, 12 Sep 2026 08:57:41 +0200 Message-ID: <20260912065536.713781139@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivas Kandagatla [ Upstream commit 6ccec91c3535b07310e12d32fe9c67ff8d31d965 ] find_first_zero_bit(mask, n) returns n (not n+1) when all bits are set, so the guard `pn > maxport` is never true on exhaustion. The driver would silently call set_bit(maxport, port_mask) and assign the out-of-range port instead of returning -EBUSY. Fix the comparison to `pn >= maxport`. Fixes: 02efb49aa805 ("soundwire: qcom: add support for SoundWire controller") Reported-by: sashiko-bot Assisted-by: Claude Sonnet 4.6 Signed-off-by: Srinivas Kandagatla Link: https://patch.msgid.link/20260701193006.4113-2-srinivas.kandagatla@oss.qualcomm.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/qcom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index e3b52d5aa411e..7f147d9ed1433 100644 --- a/drivers/soundwire/qcom.c +++ b/drivers/soundwire/qcom.c @@ -936,7 +936,7 @@ static int qcom_swrm_stream_alloc_ports(struct qcom_swrm_ctrl *ctrl, else pn = find_first_zero_bit(port_mask, maxport); - if (pn > maxport) { + if (pn >= maxport) { dev_err(ctrl->dev, "All ports busy\n"); ret = -EBUSY; goto err; -- 2.53.0