From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBED8331A6E; Sat, 12 Sep 2026 18:46:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789238765; cv=none; b=s6fsceVtGy2kwpx325rmS3o5jGMMCtcLv8NdbEz9DfwizhnT0xex4oG4h4Wiv/Jos4Durd0tauyVyXqe/nrKxvpRTpQr0yZKrrJfYwBeDIUMDyLuoImaF9pXWF81EkfxTp3+GHjNX7jpuSqi9R/Q3ve9nBel4kudSXYasn91HPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789238765; c=relaxed/simple; bh=TteiQtuXLWejC2gy9iA945dLOhp//1Fni7a9Hd3HyBc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sSUA/c2z5h/JZX0+qoGzy4Rlgc48/ElhY8F8FbY/JstTBRfiKvPf3YagqN88q0Y39Ye997nYnlQrJcKW2LBuk3XVxGOCQhdraMcDt9+65nl78EKBF6ucfOBvBfo3EsT5vt7CjaAvNmJqX01a+1+YXEiCdA+H46yOPmMeA87KyiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=L0ve4A+P; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="L0ve4A+P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE11F1F000FF; Sat, 12 Sep 2026 18:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789238763; bh=7U5hTfC0LNLmuroZzToD7RzLwmHex8m2nUoM4KSfHDc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=L0ve4A+P2skn3WRYqop7Wmrz4jJdeePuZB/mGL6n/Yg8ar+Ky5n7WbxslJvnYb/A0 vY+cF4XX14G0B3s5ra4FebonU+Stjano+po65xH8aZ5JjghgoBzPlecU2o6ZFLCnKp 4fX+VLBXJ/mjgIZfdqlIubTC5ZH52eHFopvY6eKs= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Zhongqiu Han , Christian Loehle , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 5.15 527/935] cpufreq: schedutil: Fix self-contradictory comment in sugov_iowait_apply() Date: Sat, 12 Sep 2026 08:59:17 +0200 Message-ID: <20260912065538.909814997@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Zhongqiu Han [ Upstream commit db6a017c91b774c15b1b890db45981eacfff540e ] The kerneldoc of sugov_iowait_apply() says the IO boost value is increased in sugov_iowait_apply() and, in the same sentence, that it is decreased by the same function. That is self-contradictory, and the first part is wrong: sugov_iowait_apply() only decreases the boost. The boost is actually increased in sugov_iowait_boost(). Fix the comment to name sugov_iowait_boost() as the place where the boost is increased, so it matches the code. No functional change. Fixes: fd7d5287fd65 ("cpufreq: schedutil: Cleanup and document iowait boost") Signed-off-by: Zhongqiu Han Reviewed-by: Christian Loehle Link: https://patch.msgid.link/20260703092433.4080165-1-zhongqiu.han@oss.qualcomm.com Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- kernel/sched/cpufreq_schedutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 2f7ef3f7eb1fd..8692d5e7e9ce4 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -284,7 +284,7 @@ static void sugov_iowait_boost(struct sugov_cpu *sg_cpu, u64 time, * A CPU running a task which woken up after an IO operation can have its * utilization boosted to speed up the completion of those IO operations. * The IO boost value is increased each time a task wakes up from IO, in - * sugov_iowait_apply(), and it's instead decreased by this function, + * sugov_iowait_boost(), and it's instead decreased by this function, * each time an increase has not been requested (!iowait_boost_pending). * * A CPU which also appears to have been idle for at least one tick has also -- 2.53.0