From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD65D4582D8; Sat, 12 Sep 2026 19:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240210; cv=none; b=GSFO/Fh/MCx9m7AotKhnAfHAJOQ1hvsHvYG/4YEXsK7YIKvYV5r/dBFr5kAdZJdVhpfkKI6TBzj3KOpIFYBEbWaRAt5RNaZ3HzVuNSBep9s9svmCdh1XXnU1tFU1dQo6aRCygpkt1jwhJUhoHvVvhoLXUHVBHicti7munqbDzGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240210; c=relaxed/simple; bh=6jHGBmw5gRexD+v5d57I5J983kRIIt3FuxmfAb0ATGk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Aq7qUhUB6daF0RJCoLPhbW0vRJXF4gBhR9OkIuISIZMXRNNMDfOUCZ+IiCJYPi+Yikypb7n9nQW5Ly9RSC5jSdn5/FfdvLemcTrszYKgD8ONMZc3EnWP5sp1ohI/sH0fLfWuN/c+rFXB4Cs31u+2xZdU7TGUDVvbjo7RRaI3QUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lqL0KRW8; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lqL0KRW8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94BD31F000FF; Sat, 12 Sep 2026 19:10:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789240209; bh=d2a/lTiuhHdqgktcHEG74Il6jHAWw9AWXttr1d92IcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lqL0KRW8y73eq4wFacR1zgN5HkJi+O6TSm8UMLCG1dRXLFYjUANMWtJW7XkSb8FHJ TDjkfKN0fq787p78/WFoA9Nz9rNBNEeEoPTBL5yPw7qhJsas//mxgNsth9iNmTZJig xT+2QiLWWUkclrwXHACb5aSV0O4LCOGHpd6TQxpU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Laurence Oberman , Chandrakanth Patil , "Martin K. Petersen (Oracle)" , Sasha Levin Subject: [PATCH 5.15 823/935] scsi: mpt3sas: Avoid freeing unallocated PCIe SGL buffers Date: Sat, 12 Sep 2026 09:04:13 +0200 Message-ID: <20260912065545.703866897@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065526.833703348@linuxfoundation.org> References: <20260912065526.833703348@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chandrakanth Patil [ Upstream commit b9f679dfe629004b593f018df33b330d799bcee4 ] _base_release_memory_pools() unconditionally frees every ioc->pcie_sg_lookup[] entry, including ones the setup loop never allocated after a partial failure, causing a "bad dma" warning on debug kernels or a NULL pointer dereference otherwise. Fixes: dbec4c9040ed ("scsi: mpt3sas: lockless command submission") Reported-by: Laurence Oberman Signed-off-by: Chandrakanth Patil Link: https://patch.msgid.link/20260808151010.185603-1-chandrakanth.patil@broadcom.com Signed-off-by: Martin K. Petersen (Oracle) Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 64163090f63a8..32c8f5728d4cb 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -5713,6 +5713,8 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) if (ioc->pcie_sgl_dma_pool) { for (i = 0; i < ioc->scsiio_depth; i++) { + if (!ioc->pcie_sg_lookup[i].pcie_sgl) + continue; dma_pool_free(ioc->pcie_sgl_dma_pool, ioc->pcie_sg_lookup[i].pcie_sgl, ioc->pcie_sg_lookup[i].pcie_sgl_dma); -- 2.53.0