From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0800478E25; Sat, 12 Sep 2026 15:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789227736; cv=none; b=NrtzEKmkCkkzP+BaNjn/P5Dha6c6oI6Cd5FPVJw0GHYQS17eNx238UAq23S7Yq6qDkE8wOZZRIMi5qfXIFAhKnP80KAtorJ7LcGjwiaNgfqulUP6ilkwgSjcc45j4UOdyl/zIV0iugdCwAmbylP7ow2mYunBowBm2TuD1M3RizM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789227736; c=relaxed/simple; bh=DiAjanomZYJcr7yJ+fISOCBDl0K0n3gLDWyFeO7oOzc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aOkfmVfGQkqtK6LByw6Kaz/xVb5ybaDIH5yjD9kUTeODM70y0TCf5+UylhPGy3J4IkTTm3g72DjoRG2h9v8ZLKfba4FMXEzX9Y1BHpusnumvk7S05Vx+3X36cdCO51i+SKPSRgUBuezXo4f3T3uTsnQFzJQm6BMcs9L5UavdMUk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=UdM15cMN; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="UdM15cMN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD0981F000FF; Sat, 12 Sep 2026 15:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789227730; bh=Okq0+i2jXUbJJa+7YkeygqQDdbRkQAKwCSTYqVl4R4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=UdM15cMNQ04Y4Hx6BUmrnOhshCoUCIlFMWZm10Z4/W1rZMhzIPYxx0wxm6t2KTQUg PAPhl6y5c3x3eXNrNvSlOdnsC2nj3VNXDrolV0+cEQYNhnWkMGGCJWbBrnixv+Z2D+ YZw3nJZDqL+ZTZS13rx3kG9+p4X04MtstgQUBxWg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yousef Alhouseen , Corey Minyard Subject: [PATCH 6.1 0199/1191] ipmi: ipmb: validate write message length Date: Sat, 12 Sep 2026 08:48:47 +0200 Message-ID: <20260912065552.683535764@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065548.086904252@linuxfoundation.org> References: <20260912065548.086904252@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yousef Alhouseen commit 53637506884dbd5c91a89b1a3547d99d80f8ed2c upstream. ipmb_write() read message fields before validating the length byte. A zero or short write can read uninitialized stack bytes. A length smaller than the SMBus header underflows the block write length. Require a non-empty buffer and the minimum IPMB request length. Also require the length byte plus payload before parsing the message. Fixes: 51bd6f291583 ("Add support for IPMB driver") Cc: stable@vger.kernel.org Signed-off-by: Yousef Alhouseen Message-ID: <20260624175353.8592-1-alhouseenyousef@gmail.com> Signed-off-by: Corey Minyard Signed-off-by: Greg Kroah-Hartman --- drivers/char/ipmi/ipmb_dev_int.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/char/ipmi/ipmb_dev_int.c +++ b/drivers/char/ipmi/ipmb_dev_int.c @@ -141,13 +141,14 @@ static ssize_t ipmb_write(struct file *f u8 msg[MAX_MSG_LEN]; ssize_t ret; - if (count > sizeof(msg)) + if (!count || count > sizeof(msg)) return -EINVAL; if (copy_from_user(&msg, buf, count)) return -EFAULT; - if (count < msg[0]) + if (msg[IPMB_MSG_LEN_IDX] < IPMB_REQUEST_LEN_MIN || + count < (size_t)msg[IPMB_MSG_LEN_IDX] + 1) return -EINVAL; rq_sa = GET_7BIT_ADDR(msg[RQ_SA_8BIT_IDX]);