From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 124C71FBEA6; Sat, 12 Sep 2026 15:52:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228339; cv=none; b=lECOzkT1hpdjrdsXLq55yEpMJhOU/BJ0w7P6AuN+gXZXD20kuzN0qK3li/8+P+Fl8WQQSP1rioBFKjn9KOuytGFtoTjQ2CIffKIXYwbbpFhDUJePvDCwpKeGwmUjPRYel27238/arFELi03Tpub1ZNRrVgw5elWNtoP63H/GAxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789228339; c=relaxed/simple; bh=j4ZGoLvSj2+vYs4ix0/e51CKoTu3yCsoHZh1BGd3RAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VyBlVw+MRLAQlmmyDE0hA9ItLLuCxjQXmi2uQiD48ZWRVYQfaxA2xRgbPfdYeDAnSnew9TGsETLJag04RbeJ2wt/FbklTWea6a/29kNA1i+Z4Olhq+3UZdAC+LMyaipfpVj8F4yZ0fqqa1mYsEHzwSTuLRqoDxB4ZTHNxDvKl5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lD17k/gd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lD17k/gd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 037501F000FF; Sat, 12 Sep 2026 15:52:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789228338; bh=NE3OU51KY1TKA6w19mJqrs2mcdbYaJNg9Hrt505TyVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lD17k/gd6wAEvN9Ui5qXMtEvIQtB5wsDYKtV9s+zD2FZKxx0c293DASW0m09ws85V YfYkfLCAWeif/IGggHw/xNYBmceGseSJAYzZTQ3mzXRz8wldsqq/S1LqTMg/QIaPAu gat76rWSu9HHJn/9zhmct5tudFvgIzQ4nLiPk9/A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dawei Feng , Jernej Skrabec , Dan Carpenter , Nicolas Dufresne , Hans Verkuil Subject: [PATCH 6.1 0364/1191] media: cedrus: fix memory leak in cedrus_init_ctrls() Date: Sat, 12 Sep 2026 08:51:32 +0200 Message-ID: <20260912065556.404298306@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065548.086904252@linuxfoundation.org> References: <20260912065548.086904252@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dawei Feng commit 9df2fbe563194da1967a5db083442186c1323efe upstream. In cedrus_init_ctrls(), the V4L2 control handler is initialized before allocating memory for ctx->ctrls. If this allocation fails, the function returns -ENOMEM without freeing the previously allocated handler resources, leading to a memory leak. Fix this by calling v4l2_ctrl_handler_free() on the ctx->ctrls allocation failure path. The bug was first flagged by an experimental analysis tool we are developing for kernel memory-management bugs while analyzing v6.13-rc1. The tool is still under development and is not yet publicly available. Manual inspection confirms that the bug is still present in v7.1.1. An x86_64 allyesconfig build showed no new warnings. As we do not have an Allwinner SoC or board with a Cedrus VPU available to test with, no runtime testing was able to be performed. Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Cc: stable@vger.kernel.org Signed-off-by: Dawei Feng Acked-by: Jernej Skrabec Reviewed-by: Dan Carpenter Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -271,8 +271,10 @@ static int cedrus_init_ctrls(struct cedr ctrl_size = sizeof(ctrl) * CEDRUS_CONTROLS_COUNT + 1; ctx->ctrls = kzalloc(ctrl_size, GFP_KERNEL); - if (!ctx->ctrls) + if (!ctx->ctrls) { + v4l2_ctrl_handler_free(hdl); return -ENOMEM; + } for (i = 0; i < CEDRUS_CONTROLS_COUNT; i++) { ctrl = v4l2_ctrl_new_custom(hdl, &cedrus_controls[i].cfg,