From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D9727FB37; Sat, 12 Sep 2026 16:21:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789230078; cv=none; b=ueOCi2wdXiyCC7NnE3bttFJPRyNbFfOkimQVeC6fR62aYogE10k/FJ2GUISZR0mi61uiDGCMQPzp2gKpO128W7E1WmKDkTBj1I817Y8O0wOOI87zw8noMhm6EM8e2BJtmm9volfUqtNsVywfp8oMyI+7wPDkrY3PDk25MWeHBSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789230078; c=relaxed/simple; bh=0iuIZXxiQm0+FJpZ7KmBVPDBnnpDLav4J9TvI7aykAY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PwYV/qb+Uh3/kY4kX0jaegKEi0iaSWn5hAXFzB2si4PXISILEZCUo0OW4epTfyVT5SJ9AZisssd+WnNJEh7M1mtg0KsRUPMrnOnSXuVJLjUzGYQcXR6qYnAx271YLuAI38nC9TVAO+63KkItPRwoWZlpYv058sebZ+ny3lyNWfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XnhVh6B3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XnhVh6B3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC20E1F000FF; Sat, 12 Sep 2026 16:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789230076; bh=d1OyXTmJdU/QWGpkvSY1j44HpjIQ7eS9igw9XXG4DWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XnhVh6B3k9cnq8wMGRPjKjnK4sl0QeHUqy0Tn/0wnq5QeLpHgjA5xi0JHPFLsfiAO gfGi+Z+Y5B8/Qz7VXbAhpY7A/4d+4SHn/puJ5PlicUfjcJlfxr/kUSpsss0rtsXobj uT7hAPqIM4mgU1LAJ36rxNMT/eKOprmvTId2SpUc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Patrisious Haddad , Michael Guralnik , Edward Srouji , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.1 0693/1191] RDMA/core: Fix potential use after free in ib_free_cq() Date: Sat, 12 Sep 2026 08:57:01 +0200 Message-ID: <20260912065603.826059272@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065548.086904252@linuxfoundation.org> References: <20260912065548.086904252@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Patrisious Haddad [ Upstream commit 29dc2f8e1c97372c2871a70088707933515fbd5b ] When accessing a CQ via the netlink path the only synchronization mechanism for the said CQ is rdma_restrack_get(). Currently, rdma_restrack_del() is invoked at the end of ib_free_cq(), which is too late, since by that point vendor-specific resources associated with the CQ might already be freed. This can leave a short window where the CQ remains accessible through restrack, leading to a potential use-after-free. Fix this by moving the rdma_restrack_del() call to be before the freeing of the vendor-specific resources ensuring that the CQ is removed from restrack before its internal resources are released. This guarantees that no new users hold references to a CQ that is in the process of destruction. Fixes: 43d781b9fa56 ("RDMA: Allow fail of destroy CQ") Signed-off-by: Patrisious Haddad Reviewed-by: Michael Guralnik Signed-off-by: Edward Srouji Link: https://patch.msgid.link/20260713-restrack-uaf-fix-resub-v2-6-bbe8bb270d51@nvidia.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/core/cq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/cq.c b/drivers/infiniband/core/cq.c index 584537c71545c..4ea0dfcff95ea 100644 --- a/drivers/infiniband/core/cq.c +++ b/drivers/infiniband/core/cq.c @@ -324,6 +324,7 @@ void ib_free_cq(struct ib_cq *cq) if (WARN_ON_ONCE(cq->cqe_used)) return; + rdma_restrack_del(&cq->res); if (cq->device->ops.pre_destroy_cq) { ret = cq->device->ops.pre_destroy_cq(cq); WARN_ONCE(ret, "Disable of kernel CQ shouldn't fail"); @@ -350,7 +351,6 @@ void ib_free_cq(struct ib_cq *cq) else ret = cq->device->ops.destroy_cq(cq, NULL); WARN_ONCE(ret, "Destroy of kernel CQ shouldn't fail"); - rdma_restrack_del(&cq->res); kfree(cq->wc); kfree(cq); } -- 2.53.0