From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25407390615; Sat, 12 Sep 2026 16:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789230650; cv=none; b=ijwKaQmCE7gEGjQCBuG7o1sHIRrQ+mADv11MIVD+IfoCdl8LzZc/L77yt9NLxo3Sslr4r4ZLZKx5Rj72F0frwMeUbhPvrb5UVUkXWDjjc2YdI028PqO42Fj0PRkP+ZpOQcfTeLoEO96DR48rfjKQInV/DOuB1XYjhkiK960BYPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789230650; c=relaxed/simple; bh=BBeTytEuVYasTqLG2XCaE2suz2BGECIKA4SawYQOAfA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FXD2robpuzLd3qvHy8up9qBcBaYHPirmtJNoBXs7nBzoArvDvPXD4Gz5eugBlZN7IraTiTAkwWIYqgLeUnj4/hQY3frHMFJ+iz4h01yrz4wf239lOhcuAddgffEY2ruRIp7o1oz0gy6o6ajyz8kS0pf2V6ymsC3kWEPqicoAFNg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=femtd+q/; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="femtd+q/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10CB01F000FF; Sat, 12 Sep 2026 16:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789230649; bh=W1pztZhCZbUECrmlrhlaeLpTjS2TlFxCAxjtB/0TPUM=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=femtd+q/cbXS6dSiCuH755Cuc+X/hPMUOgz0ebXgI6VDaSEYpmk/bol3Nq8HeDop0 1JaIGqML1+qBRkcA6VHZgD/CAA/yKeGJqK5z09+SHaT4NWiMC+9mvXj7Kq8ZdkEFU7 wn3DVcBqxHEIbcFLGO/hFVuwcyh3DSsTm2iIsxnY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+9eebf5f6544c5e873858@syzkaller.appspotmail.com, Yousef Alhouseen , Jiri Kosina , Sasha Levin Subject: [PATCH 6.1 0838/1191] HID: synchronize input before cleaning up a failed probe Date: Sat, 12 Sep 2026 08:59:26 +0200 Message-ID: <20260912065607.080935400@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065548.086904252@linuxfoundation.org> References: <20260912065548.086904252@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yousef Alhouseen [ Upstream commit 207853d46f7ef2e28042344a1468da8754c3ddbf ] hid_device_io_start() allows reports to run concurrently with probe. If the probe subsequently fails, __hid_device_probe() releases driver resources and clears hdev->driver without first excluding those report callbacks. For example, a report may enter hidraw_report_event() while the failure path frees the associated hidraw object, leading to a use-after-free when the report takes the object's list lock. Stop input before performing failed-probe cleanup. This reacquires driver_input_lock and waits for any report callback already in progress. Fixes: c849a6143bec ("HID: Separate struct hid_device's driver_lock into two locks.") Reported-by: syzbot+9eebf5f6544c5e873858@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=9eebf5f6544c5e873858 Signed-off-by: Yousef Alhouseen Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hid-core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 6a0552884c7d7..d02a9b1b1467a 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -2691,6 +2691,8 @@ static int __hid_device_probe(struct hid_device *hdev, struct hid_driver *hdrv) */ if (ret) { + if (hdev->io_started) + hid_device_io_stop(hdev); devres_release_group(&hdev->dev, hdev->devres_group_id); hid_close_report(hdev); hdev->driver = NULL; -- 2.53.0