From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B024611E1; Sat, 12 Sep 2026 13:31:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789219863; cv=none; b=TF4HkCFQc3Fr1XITa0Ds6iq4GMFzSmHTYQ9rnVT/U2GS/2C7w5jEvVwsAwibGxS4sZx4yJgFmJcR8+njunNcIC2FT+4ihCp888APWd34dlDkXsOGb1osKf2hxOyq2nQch5xSKWkNoisxUxBr+YDWh4QVi7LSwXShv9ftv8aaMZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789219863; c=relaxed/simple; bh=Fa9gX4FxHIwGWHkjsksq73V8T12zVD9mRHaADNj4czI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GrtRKOksxNW1SIk3nUndzTMVosT5i+rPG9pw6T2xiRoMy0SOx46QIif/QtDTqb6vQQbjPw7aMtL74rlUJOh9iC+SKZn5pWJV/dl0Sh3BNgCJ0yWO5nWJttqR4ckHFwGZSCMpARgxOYqprTis1K9KEhsxUJ3DaRMQ4te0/l0n0J4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LXPz6k9z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LXPz6k9z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60B801F000FF; Sat, 12 Sep 2026 13:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789219862; bh=jGODebKHcxWnbAnPxlfxNXbwyucLdMpw2r/ERYidC9o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LXPz6k9z7iDmrPuZQxsTjlhiGNYknnQ/a4BnLyUzSd4juv2TBZr9gz9iZewg+gV/n kEGSlELIrXUoLdo3xQrhOaFa+n7qg6ejbIabpxcE10ZQdxObnpSYFhaGv5bOW0ddHx ckuckO2B1vCedzaUltFRWXdMiTHiPHmqMqJHdE/A= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeff Layton , Chuck Lever Subject: [PATCH 6.6 0059/1424] nfsd: check client ownership when cancelling a copy-notify stateid Date: Sat, 12 Sep 2026 08:41:31 +0200 Message-ID: <20260912065608.624698676@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeff Layton commit 6bdbfab96e0cf25e5f57dac5c09dc1749751a4bf upstream. On the OFFLOAD_CANCEL path (clp != NULL), manage_cpntf_state() freed the target cpntf state without checking ownership. The lookup key st->si_opaque.so_id is allocated cyclically (guessable) and the embedded clientid is the fixed per-net nn->s2s_cp_cl_id, so any authenticated NFSv4.2 client could cancel and free another client's copy-notify stateid. Compare the creating clientid recorded in state->cp_p_clid against the requesting client's cl_clientid and return nfserr_bad_stateid on a mismatch instead of freeing the entry. Fixes: ce0887ac96d3 ("NFSD add nfs4 inter ssc to nfsd4_copy") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Jeff Layton Link: https://patch.msgid.link/20260710-nfsd-testing-v3-5-a0ff7db6aa3e@kernel.org Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfs4state.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) --- a/fs/nfsd/nfs4state.c +++ b/fs/nfsd/nfs4state.c @@ -6660,10 +6660,20 @@ __be32 manage_cpntf_state(struct nfsd_ne state = NULL; goto unlock; } - if (!clp) + if (!clp) { refcount_inc(&state->cp_stateid.cs_count); - else + } else if (memcmp(&clp->cl_clientid, &state->cp_p_clid, + sizeof(clientid_t))) { + /* + * OFFLOAD_CANCEL: only the creating client may cancel. + * so_id is guessable, so without this check any client + * could free another's cpntf state. + */ + state = NULL; + goto unlock; + } else { _free_cpntf_state_locked(nn, state); + } } unlock: spin_unlock(&nn->s2s_cp_lock);