From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7DDF47D466; Sat, 12 Sep 2026 13:32:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789219968; cv=none; b=L0cAvqLvoz1N51FWfkViST0sPOHkgTnj7ISNTC2xtvet1cyWwyb8ilmKoB1IJsIa7vd9WqLXVv3z8uOEPou786IFeCW6EVPkmoEfNuy3hd0Qtw9vGvVzpozUjTnb6Jp5aKQhW3wfNAga6g5qIAZh9s6lfXXUEfBkMZJy4U0pftc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789219968; c=relaxed/simple; bh=YznhDNnlmeKAMEzRymbppXCqFKSdpzxRFvpoSYqdHKo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZG9avNNpFXI+s33ZGULdmNQ0fdBxe4tQHwvVC6aF53SCDxHp2UL8XYNOmMHjfqNFtClG8eli0eCIQuUg63xUHkN3odT+DChVOTPahjd2CQDDw71x8B4jrvlMfSD9XKtZAQLmpZ2il3XMNtPIgwohWJfIwg45DCQL+UFHZ8Zgl3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RFbuyxv1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RFbuyxv1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB2681F000FF; Sat, 12 Sep 2026 13:32:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789219967; bh=WYzgZ35BAV3hz7mIub3hkmxna6HPItVFa0BoBVZZRsA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RFbuyxv1SolqY7offpAlYYaKrzmXwCyhqi0ih7IK8FPgbieVpOaXf1FTcuoiL5RRU FEZBcOnnJ5DZrygzpJZ02mICTWwyobbMB0vAYwL8/2d/BO9fKTsD5B0I5rYgNzxa6H 6YMJ+WbVQlsbREVBHMFQCpBuToZYyWz7Rz4dSK6E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Paulo Alcantara , Frank Sorenson , Namjae Jeon Subject: [PATCH 6.6 0082/1424] smb: client: fix copy-paste error in WSL EA length accounting for $LXDEV Date: Sat, 12 Sep 2026 08:41:54 +0200 Message-ID: <20260912065609.145172550@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Sorenson commit 5d14030b46af1a958fd104b020fbb93631c98822 upstream. The LXDEV block in cifs_query_path_info() uses SMB2_WSL_XATTR_MODE_SIZE (4) instead of SMB2_WSL_XATTR_DEV_SIZE (8), undercounting eas_len by 4 bytes per $LXDEV EA. eas_len is used only as a zero/non-zero presence flag so there is no current functional impact, but the value is incorrect and misleading. Fixes: 97db41604555 ("smb: client: parse uid, gid, mode and dev from WSL reparse points") Cc: stable@vger.kernel.org Cc: Paulo Alcantara Signed-off-by: Frank Sorenson Acked-by: Namjae Jeon Signed-off-by: Paulo Alcantara Signed-off-by: Greg Kroah-Hartman --- fs/smb/client/smb1ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/smb/client/smb1ops.c +++ b/fs/smb/client/smb1ops.c @@ -747,7 +747,7 @@ static int cifs_query_path_info(const un ea->ea_value_length = cpu_to_le16(SMB2_WSL_XATTR_DEV_SIZE); memcpy(&ea->ea_data[0], SMB2_WSL_XATTR_DEV, SMB2_WSL_XATTR_NAME_LEN + 1); data->wsl.eas_len += ALIGN(sizeof(*ea) + SMB2_WSL_XATTR_NAME_LEN + 1 + - SMB2_WSL_XATTR_MODE_SIZE, 4); + SMB2_WSL_XATTR_DEV_SIZE, 4); rc = 0; } else if (rc >= 0) { /* It is an error if EA $LXDEV has wrong size. */