From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28D8047124F; Sat, 12 Sep 2026 13:36:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220199; cv=none; b=eqP790D4s0nJ5B2hvbQfNo4EmwzLGw9Vfw/IBFLz50rk2ZvotasS/omftq7LMlD7PVXVYgAUpl8rXsUqvAC5Jx1vl7IrzCyVvQH9QBnE6r/0HE+1vtHw7WJnbc8EBcxGg7yXUU8SaOCe8tY1IleGgi41w79u/qb8EECRWeWd0Ww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220199; c=relaxed/simple; bh=q8SCYi3tQaeYY1aVH2vDenRsxKOhBx3sQ7AHjp7ojg0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tkEcB/HmwV1J3aYAqmK0VW/fAH0uSWrrUglYf2/nVEBEq3b7O0tZ7VokCImcDFkv4dBsUoFOt847wDo8O7kv8s7Dq0jFanjw4vNkQZyCD9jmRzk6Rktu5g2SN/N3UfmdDOaScsgkIVy+DMQVIOMlgxRLyjhiUaZ+tbgHw7JxH1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DLC6wlkG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DLC6wlkG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FE291F000FF; Sat, 12 Sep 2026 13:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789220198; bh=QicwS6CwSGY6xxLjRIzFYSzanivXM3G1ikr8Mxeqj5g=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DLC6wlkGzH9/GpiKad5YYF5bpXsoYM0eowvF3MmJXUfg1WbsacekfzbUV2pAEPafA cWzV7btZm22y8g/fWBo5ZqoB8XLtuTo0O1cyialxdVWsxsa9BdO8ir2wk6zP9B9sHb TMmPugMF5McmNuFWMdVoAtPO4OFcR5lb1gysTRUM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gongwei Li , Luiz Augusto von Dentz Subject: [PATCH 6.6 0129/1424] Bluetooth: hci_uart: Fix false success return in hci_uart_setup() Date: Sat, 12 Sep 2026 08:42:41 +0200 Message-ID: <20260912065610.188281713@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gongwei Li commit a9355799343e10014f2acfd4b6844d2335ecafea upstream. When reading the local version information for vendor detection fails, the error is only printed and 0 is returned, which masks the setup failure from the HCI core. Return PTR_ERR(skb) instead. Fixes: fb2ce8d11f039 ("Bluetooth: hci_uart: Add support for vendor detection flag") Fixes: 82f5169bf3d3b ("Bluetooth: hci_uart: add serdev driver support library") Cc: stable@vger.kernel.org Signed-off-by: Gongwei Li Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/hci_ldisc.c | 2 +- drivers/bluetooth/hci_serdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/bluetooth/hci_ldisc.c +++ b/drivers/bluetooth/hci_ldisc.c @@ -445,7 +445,7 @@ static int hci_uart_setup(struct hci_dev if (IS_ERR(skb)) { BT_ERR("%s: Reading local version information failed (%ld)", hdev->name, PTR_ERR(skb)); - return 0; + return PTR_ERR(skb); } if (skb->len != sizeof(*ver)) { --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -221,7 +221,7 @@ static int hci_uart_setup(struct hci_dev if (IS_ERR(skb)) { bt_dev_err(hdev, "Reading local version info failed (%ld)", PTR_ERR(skb)); - return 0; + return PTR_ERR(skb); } if (skb->len != sizeof(*ver))