From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E71361DDC; Sat, 12 Sep 2026 13:40:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220433; cv=none; b=L7ksDgTMU4DzVU7MfDSu39Q18Mynzpys/i/NIOCaBXixR6N3vRdsobjbZQ31f9vf30AXyjca3kseElnhyQac6XRpSuuiWISCOKVPoxpIXKfUEqs6IZRVM+g4kjOWjDFETqDq1rDNXOWspQ9mcoIdzb9FrQSeh4GZbhYKtBuFXwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789220433; c=relaxed/simple; bh=QTIfVFDicvwz4hOiHn+MGbWgpGRv776AfK88x6qzINI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=td7JBWsUttYGtD+FtlDLiy3G5fNII+gGc+km5KMgFS/95yvJpi23b2Y00WKVE1znmECj+xI6lKgFWoP0m80Gqn1sRvID4bCbhGRlnuqIDWcQ5iZtjMxvuH2sw8kIIeORuXMwEwkX++S9cGOikjJne6hanyJIQQp6aPNCagTRRVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FyIyJg77; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FyIyJg77" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3EA8A1F000FF; Sat, 12 Sep 2026 13:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789220432; bh=YdhV7p1u2r3MU/BtDgMJH8injGMl4Q8brl3waC+Qh4Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FyIyJg77jtH5pGl43pBWlI86aJc3YnM9HocTBAURNRxdoUsLpXYN2NMWRCEDU4B2a OCyfeKq/yC5KRhaF5GSw5RRpZY/cjmnjTlZp1EITwo+aIPR9QMXQab7VO7JzLWGL77 O7g3J5ddBT63SiXoXdf3qkR6dCCbK9uoj38Iws8Y= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yifei Gao , Mike Marshall Subject: [PATCH 6.6 0177/1424] orangefs: fix double-free of trailer_buf on readdir copy failure Date: Sat, 12 Sep 2026 08:43:29 +0200 Message-ID: <20260912065611.255711018@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yifei Gao commit f574296be7f46eb60beca851240b526df232f480 upstream. On a readdir downcall, orangefs_devreq_write_iter() frees op->downcall.trailer_buf with vfree() when copy_from_iter_full() fails, but does not clear the pointer before goto Efault. The waiter in do_readdir() is then woken with a negative status and frees the same pointer again on its r < 0 path, causing a deterministic double-free. A client holding /dev/pvfs2-req triggers it by sending a readdir downcall whose declared trailer_size exceeds the bytes it supplies. Clear the pointer after freeing so the readdir-side vfree() becomes a no-op. Fixes: 382f4581e67f ("orangefs: rewrite readdir to fix several bugs") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Yifei Gao Signed-off-by: Mike Marshall Signed-off-by: Greg Kroah-Hartman --- fs/orangefs/devorangefs-req.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/orangefs/devorangefs-req.c +++ b/fs/orangefs/devorangefs-req.c @@ -474,6 +474,7 @@ static ssize_t orangefs_devreq_write_ite op->downcall.trailer_size, iter)) { gossip_err("%s: failed to copy trailer.\n", __func__); vfree(op->downcall.trailer_buf); + op->downcall.trailer_buf = NULL; goto Efault; }