From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AEB32ED40; Sat, 12 Sep 2026 13:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789221160; cv=none; b=CYvBeegqmEqVPGPU6ytRlc+3LSbCGAEa/ovkyHyvDBUg06RtPLRZLPYi7FXlSjE9XN8Q/fiGkuv3QTwWSJyoITibgR5AJJ4y3rJw+SrwJ7JGzdZxDKubmbhB5PIwiWkIIjCyy0oEvmOVyOlJk6RSlwX/nXQUP0EbhJVZ7R4V1fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789221160; c=relaxed/simple; bh=DSHkGjXZc5og76WD/5EvMuhc7A9OzeulqgBVxkfK6gc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=U05A4FLY4Lnd0Qjqk1NWX/rhoe9tdeeTnrFuVUmpJj0wMt4DIEgZzFUsRzbBHezeVI4RheDSXrm0eNzhzQUi1UL7++lq4Ee981qUv2o6SlKx47iaKItMP3BV0I5wKLUpjtOkHILpkCsGa+ETkbEOISfA3JaI6WsSpxGVPoZC7+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yph4uFWB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yph4uFWB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2A8241F000FF; Sat, 12 Sep 2026 13:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789221158; bh=F8anDYc20G1b2ND9xnpljhtTrb2mmbvN/BSOVFOnV5k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yph4uFWB2fY8JyjsId4uI+DySwRxfvSGl/pXZimu/QO4+wryzIn6Dol0VXdguRUH2 CNkmXQ62BzA8oBF6MUaX/rHONOU9WhzEhPCUYKoCGuxpjPGxZl95TOvkh0731zEJ4g iuDJ4oB5DQJUwfJ1kEPfZOnQoBduYnx5pXGjc6o8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+22ea20ef3afb6785b122@syzkaller.appspotmail.com, stable , Liu Qi , Alan Stern Subject: [PATCH 6.6 0326/1424] usb-storage: ene_ub6250: fix race between scan work and probe Date: Sat, 12 Sep 2026 08:45:58 +0200 Message-ID: <20260912065614.586448650@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Liu Qi commit 445fc368c6bc73eff0aeb3818cf5f355facfbb16 upstream. ene_ub6250_probe() calls usb_stor_probe2(), which starts the usb-storage infrastructure and schedules the delayed scan work. The driver then calls ene_get_card_type(), which sends an ENE command through ene_send_scsi_cmd() and the usb-storage bulk transfer helpers. Both the delayed scan work, through usb_stor_Bulk_max_lun(), and ene_get_card_type() use us->current_urb. The scan work serializes this access with us->dev_mutex, but the ENE card-type probe does not. If the scan work runs while ene_get_card_type() is still using us->current_urb, usb_submit_urb() warns that the URB is already active. Serialize ene_get_card_type() with us->dev_mutex, matching the locking used by the scan path. Reported-by: syzbot+22ea20ef3afb6785b122@syzkaller.appspotmail.com Cc: stable Closes: https://syzkaller.appspot.com/bug?extid=22ea20ef3afb6785b122 Assisted-by: Qwen:Qwen3.6 Signed-off-by: Liu Qi Acked-by: Alan Stern Link: https://patch.msgid.link/20260821090416.1247127-1-liuqi@longcheer.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/storage/ene_ub6250.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/storage/ene_ub6250.c +++ b/drivers/usb/storage/ene_ub6250.c @@ -2358,7 +2358,9 @@ static int ene_ub6250_probe(struct usb_i return result; /* probe card type */ + mutex_lock(&us->dev_mutex); result = ene_get_card_type(us, REG_CARD_STATUS, info->bbuf); + mutex_unlock(&us->dev_mutex); if (result != USB_STOR_XFER_GOOD) { usb_stor_disconnect(intf); return USB_STOR_TRANSPORT_ERROR;