From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632452FFF9D; Sat, 12 Sep 2026 14:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789221665; cv=none; b=ZDAAADxqr+GFRlN26BuAdZRWxm0PA/2wuizyMFWSaAKzy7rLT8xys/oGc3N1hKoNsqbk7o0C18XCGYcokZ6CPQXS2PdRqqGG6swnSte2CuKrzSW57W+DJ1w/YkvoAAoxswUwbe0NpWoXRBHRxJudzsogl1JnWmSpgsdJiNP/AdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789221665; c=relaxed/simple; bh=a89ZsZPdvDCrbZ+ILYPUEyKI0bDt1qrR1BDGPOG2csA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ef6gR3av9Lr66KNUziiEOBhum4cT73AYR7oK/8r1CxDgdlIO3BSLX580jfRm5wCBrd4Cxd7CVl+A42mLJ+nuKzfYAYUT0C1T/oGnD03tv7mfH8zh5HELNuJ/3Ec0Fffzx9r1tl5g7jVk+hN6/YBeYwJtZE7TuqnI3LWCxvR5OR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BYCNumk1; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BYCNumk1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9D6E1F000FF; Sat, 12 Sep 2026 14:01:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789221664; bh=0ZsXBmqOX7699/pcMbaLCk4Sf1lyO34DHvTToNBo9M0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BYCNumk1XADIhVCAxtvhj3FLygTRybDkHDvgkdIxymK2QyxzZWGOA5uUeMeXOfDUP xrr+SiKw1h3qGyEvMUg493COPJBC5PCwW2tvqiVwkPFsTOMOfBkRRRsu+N2TmX4kD1 y/mIzeYxA2jd/7fczHeetLJJtHKZWUp0XgvukLMI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yosry Ahmed , Kai Huang , Jim Mattson , Sean Christopherson Subject: [PATCH 6.6 0428/1424] KVM: nVMX: Always flush vpid02 on first use Date: Sat, 12 Sep 2026 08:47:40 +0200 Message-ID: <20260912065616.868204507@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.279695368@linuxfoundation.org> References: <20260912065607.279695368@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yosry Ahmed commit f0772389413dce9657c7d6950abf3edbbd511356 upstream. Make sure vpid02 is always flushed on first use by setting last_vpid=0 when allocating vpid02. nested_vmx_transition_tlb_flush() will always detect a VPID change on first VM-Enter after VMXON, because VPID=0 in vmcs12 is not allowed if L1 enables VPID. This avoids using stale TLB entries from a previous lifetime of the VPID, that might have been associated with a different vCPU (or a completely different VM). Note that last_vpid is already being initialized as 0 when the vCPU is created, but it is not reset when vpid02 is freed on VMXOFF. Hence, the problem can only occur if L1 does VMXOFF -> VMXON, runs an L2, and KVM happens to reuse a VPID that has TLB entries on the physical CPU. Cc: stable@vger.kernel.org Signed-off-by: Yosry Ahmed Reviewed-by: Kai Huang Reviewed-by: Jim Mattson Link: https://patch.msgid.link/20260616214652.2157032-2-yosry@kernel.org Signed-off-by: Sean Christopherson Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/vmx/nested.c | 10 ++++++++++ 1 file changed, 10 insertions(+) --- a/arch/x86/kvm/vmx/nested.c +++ b/arch/x86/kvm/vmx/nested.c @@ -1187,6 +1187,9 @@ static void nested_vmx_transition_tlb_fl * is the VPID incorporated into the MMU context. I.e. KVM must assume * that the new vpid12 has never been used and thus represents a new * guest ASID that cannot have entries in the TLB. + * + * Note, last_vpid is initialized as 0, so the first nested VM-Enter + * after VMXON will always flush the TLB to avoid using stale entries. */ if (is_vmenter && vmcs12->virtual_processor_id != vmx->nested.last_vpid) { vmx->nested.last_vpid = vmcs12->virtual_processor_id; @@ -5190,6 +5193,13 @@ static int enter_vmx_operation(struct kv vmx->nested.vpid02 = allocate_vpid(); + /* + * Clear last_vpid to ensure that the VPID is flushed on the first + * nested VM-Enter. Otherwise, stale TLB entries from a previous life of + * the VPID (e.g. different vCPU or even different VM) could be used. + */ + vmx->nested.last_vpid = 0; + vmx->nested.vmcs02_initialized = false; vmx->nested.vmxon = true;