From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98E8433F59A; Sat, 12 Sep 2026 12:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789215130; cv=none; b=nFhgvJx3w/8epebWGbBXjc79ojjhEdtQoxrGIFzQDRRRstgBAmjUM7Es8dhp8ANF9jo/bOVBR/WbS5rPEJP3BmlYV62dGueNPH8mcgBH4F8B8WIjuE2+5syl3R69ru9kO+2L3QH+1OV/emCiuiew0Qrc6zgmJTzV6sNpQCHDCi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789215130; c=relaxed/simple; bh=Bq9yqJQ8AgpKDpXlrRMU6m359yvrBId1P3AtS6yizJ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bseu+sCoQCPTvf+2C0ZtEVc0QgKjcEoC4uo5wXA8JMQgStnb9iOZagCHJP6i8wGC1D8S3BjcMMVrTdQOXEKSaRk0qxai0MXp8f44SkYxP2zjbQPLSo8WrvMHpFUHi27InacR6+nhb23cds+a7Gcm8IWLYraaAyB9jYMq+28ETAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=yQx/bYLl; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="yQx/bYLl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F57E1F000FF; Sat, 12 Sep 2026 12:12:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789215129; bh=PhOYbY9/v56ghXsBHHg2B3DTQfi9rFonEW2+fe6jRW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=yQx/bYLlO/Hj3f2ArAy0MnyJICEFGT1sWjwSgpIOvyGJTSaUoOff718w7H4YxFmg4 vw2bD9t17Ya2788IvAxyZGc6PhtlGwwEWbVUYSzM9FSVswJhYIL9MoK/hVR+OJPRh6 Mz+tJ+tZKT2OtlH1v5ZwdDQAn9TZRZyN8rnUksPk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuvraj Singh Chauhan , Sasha Levin Subject: [PATCH 6.12 0426/1376] staging: octeon: fix free_irq dev_id mismatch in cvm_oct_rx_shutdown Date: Sat, 12 Sep 2026 08:47:32 +0200 Message-ID: <20260912065617.029670284@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065607.535295758@linuxfoundation.org> References: <20260912065607.535295758@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yuvraj Singh Chauhan [ Upstream commit 41db5b76eeb4cc11a1097384caba7cfc659f7293 ] In cvm_oct_rx_initialize(), request_irq() is called with &oct_rx_group[i].napi as the dev_id: request_irq(oct_rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &oct_rx_group[i].napi); However, cvm_oct_rx_shutdown() passes cvm_oct_device (an array of struct net_device pointers) as the dev_id to free_irq(): free_irq(oct_rx_group[i].irq, cvm_oct_device); Since __free_irq() matches the action to remove by comparing dev_id pointers, the mismatched cookie means the IRQ handler is never found, triggering a WARN and leaving the IRQ line permanently allocated. This prevents proper driver cleanup on module removal. Fix the mismatch by passing &oct_rx_group[i].napi as the dev_id to free_irq(), matching what was used during request_irq(). Signed-off-by: Yuvraj Singh Chauhan Link: https://patch.msgid.link/20260212171903.1417804-1-ysinghcin@gmail.com Signed-off-by: Greg Kroah-Hartman Stable-dep-of: c0a9a8586a63 ("staging: octeon: add missing napi_disable in cvm_oct_rx_shutdown") Signed-off-by: Sasha Levin --- drivers/staging/octeon/ethernet-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 965330eec80a8..d0b43d50b83ce 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -535,7 +535,7 @@ void cvm_oct_rx_shutdown(void) cvmx_write_csr(CVMX_POW_WQ_INT_THRX(i), 0); /* Free the interrupt handler */ - free_irq(oct_rx_group[i].irq, cvm_oct_device); + free_irq(oct_rx_group[i].irq, &oct_rx_group[i].napi); netif_napi_del(&oct_rx_group[i].napi); } -- 2.53.0